mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@aol.com>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: erofs: make use of DBG_BUGON
Date: Sat, 8 Jun 2019 20:11:36 +0800	[thread overview]
Message-ID: <0b6db3cd-25ec-49b2-93e0-31d0677507c1@aol.com> (raw)
In-Reply-To: <20190608094918.GA11605@hari-Inspiron-1545>



On 2019/6/8 ??????5:49, Hariprasad Kelam wrote:
> DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG
> (EROFS developping feature) is on.
> replace BUG_ON with DBG_BUGON.
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>

Thanks,
Gao Xiang

> ---
>  drivers/staging/erofs/unzip_vle.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/erofs/unzip_vle.h b/drivers/staging/erofs/unzip_vle.h
> index 517e5ce..902e67d 100644
> --- a/drivers/staging/erofs/unzip_vle.h
> +++ b/drivers/staging/erofs/unzip_vle.h
> @@ -147,7 +147,7 @@ static inline unsigned z_erofs_onlinepage_index(struct page *page)
>  {
>  	union z_erofs_onlinepage_converter u;
>  
> -	BUG_ON(!PagePrivate(page));
> +	DBG_BUGON(!PagePrivate(page));
>  	u.v = &page_private(page);
>  
>  	return atomic_read(u.o) >> Z_EROFS_ONLINEPAGE_INDEX_SHIFT;
> @@ -179,7 +179,7 @@ static inline void z_erofs_onlinepage_fixup(struct page *page,
>  		if (!index)
>  			return;
>  
> -		BUG_ON(id != index);
> +		DBG_BUGON(id != index);
>  	}
>  
>  	v = (index << Z_EROFS_ONLINEPAGE_INDEX_SHIFT) |
> @@ -193,7 +193,7 @@ static inline void z_erofs_onlinepage_endio(struct page *page)
>  	union z_erofs_onlinepage_converter u;
>  	unsigned v;
>  
> -	BUG_ON(!PagePrivate(page));
> +	DBG_BUGON(!PagePrivate(page));
>  	u.v = &page_private(page);
>  
>  	v = atomic_dec_return(u.o);
> 

  reply	other threads:[~2019-06-08 12:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-08  9:49 Hariprasad Kelam
2019-06-08 12:11 ` Gao Xiang [this message]
2019-06-11  1:41 ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b6db3cd-25ec-49b2-93e0-31d0677507c1@aol.com \
    --to=hsiangkao@aol.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gaoxiang25@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hariprasad.kelam@gmail.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®