mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Akanksha J N <akanksha@linux.vnet.ibm.com>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/ftrace: Limit number of lines processed in 'trace'
Date: Tue, 18 Oct 2022 16:41:20 -0600	[thread overview]
Message-ID: <0b747522-1398-5a68-0fb2-763db6aab5b8@linuxfoundation.org> (raw)
In-Reply-To: <20221017105502.307506-1-naveen.n.rao@linux.vnet.ibm.com>

On 10/17/22 04:55, Naveen N. Rao wrote:
> On very large machines, ftracetest can seem to hang or otherwise take a
> very long time to complete individual tests. This can be attributed to
> statements that try to process the entire contents of 'trace'.
> 
> Limit the number of lines processed from 'trace' to resolve this. Apart
> from the change in test.d/functions to add TRACENL, this commit is the
> result of running the below command (and fixing some whitespace errors):
>    grep -l -R 'cat trace |' -- ./tools/testing/selftests/ftrace/test.d/ | \
> 	xargs -n 1 sed --in-place -e "s/cat trace |/head -\$\{TRACENL\} trace |/g"
> 
> Reported-by: Akanksha J N <akanksha@linux.vnet.ibm.com>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>

Please cc linux-kselftest list on all selftest patches.

thanks,
-- Shuah


      parent reply	other threads:[~2022-10-18 22:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 10:55 Naveen N. Rao
2022-10-17 14:51 ` Steven Rostedt
2022-10-18 15:19   ` Masami Hiramatsu
2022-10-18 15:22     ` Steven Rostedt
2022-10-19  9:45       ` Naveen N. Rao
2022-10-19 15:46         ` Masami Hiramatsu
2022-10-28  7:29           ` Naveen N. Rao
2022-10-18 22:41 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b747522-1398-5a68-0fb2-763db6aab5b8@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=akanksha@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®