mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Devarsh Thakkar <devarsht@ti.com>
Cc: praneeth@ti.com, vigneshr@ti.com, aradhya.bhatia@linux.dev,
	s-jain1@ti.com, r-donadkar@ti.com, j-choudhary@ti.com,
	h-shenoy@ti.com, jyri.sarha@iki.fi, airlied@gmail.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
	simona@ffwll.ch, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org
Subject: Re: [PATCH v6 0/3] Add support for AM62L DSS
Date: Mon, 19 May 2025 18:20:10 +0300	[thread overview]
Message-ID: <0b796f3f-8fcc-422e-892a-3e919518d5b0@ideasonboard.com> (raw)
In-Reply-To: <20250507180631.874930-1-devarsht@ti.com>

Hi,

On 07/05/2025 21:06, Devarsh Thakkar wrote:
> This adds support for DSS subsystem present in TI's AM62L SoC
> which supports single display pipeline with DPI output which
> is also routed to DSI Tx controller within the SoC.

I think this looks fine. I did some quick tests, and didn't notice 
anything amiss. I'm still somewhat wary about the indexing we do wrt. 
planes, and the possibility to introduce hard-to-find bugs by using the 
wrong index. We can try to improve this on top.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

I'll do a few more tests, and unless there are no other commets I'll 
push to drm-misc tomorrow.

  Tomi


      parent reply	other threads:[~2025-05-19 15:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 18:06 Devarsh Thakkar
2025-05-07 18:06 ` [PATCH v6 1/3] dt-bindings: display: ti,am65x-dss: " Devarsh Thakkar
2025-05-07 18:06 ` [PATCH v6 2/3] drm/tidss: Update infrastructure to support K3 DSS cut-down versions Devarsh Thakkar
2025-05-07 18:06 ` [PATCH v6 3/3] drm/tidss: Add support for AM62L display subsystem Devarsh Thakkar
2025-05-19 15:20 ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b796f3f-8fcc-422e-892a-3e919518d5b0@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=aradhya.bhatia@linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=h-shenoy@ti.com \
    --cc=j-choudhary@ti.com \
    --cc=jyri.sarha@iki.fi \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=praneeth@ti.com \
    --cc=r-donadkar@ti.com \
    --cc=robh@kernel.org \
    --cc=s-jain1@ti.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®