From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ian Forbes <ian.forbes@broadcom.com>
Cc: Colin Ian King <colin.i.king@gmail.com>,
Zack Rusin <zack.rusin@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/vmwgfx: fix missing assignment to ts
Date: Tue, 24 Jun 2025 19:35:17 +0300 [thread overview]
Message-ID: <0b83e41e-7bb3-4e20-b568-12feaf73a79c@suswa.mountain> (raw)
In-Reply-To: <CAO6MGtiLtHKk3tuvxpz5wEC8PxshANhdP97MQ+jD9euu8UmYxQ@mail.gmail.com>
On Tue, Jun 24, 2025 at 10:02:41AM -0500, Ian Forbes wrote:
> On Mon, Jun 23, 2025 at 5:35 PM Colin Ian King <colin.i.king@gmail.com> wrote:
> >
> > The assignment to ts is missing on the call to ktime_to_timespec64.
> > Fix this by adding the missing assignment.
> >
> > Fixes: db6a94b26354 ("drm/vmwgfx: Implement dma_fence_ops properly")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Was this caught by a compiler warning? I'm surprised I didn't get some
> sort of warning for this.
>
We've disabled uninitialized variable warnings in GCC. Perhaps
Clang would have caught this but I'm not sure because tracking
uninitialized struct members is a bit more complicated than tracking
uninitialized variables.
regards,
dan carpenter
prev parent reply other threads:[~2025-06-24 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 22:35 Colin Ian King
2025-06-24 15:02 ` Ian Forbes
2025-06-24 16:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b83e41e-7bb3-4e20-b568-12feaf73a79c@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=airlied@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=colin.i.king@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ian.forbes@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®