mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
	"John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 59/62] rndis_wlan: Use static const
Date: Sat, 20 Nov 2010 18:39:00 -0800	[thread overview]
Message-ID: <0b953a3dc6bb044f9aee4033caeb1693ac0796fc.1290305776.git.joe@perches.com> (raw)
In-Reply-To: <cover.1290305773.git.joe@perches.com>

Using static const generally increases object text and decreases data size.
It also generally decreases overall object size.

   text	   data	    bss	    dec	    hex	filename
  41757	   2205	   9896	  53858	   d262	drivers/net/wireless/rndis_wlan.o.old
  41653	   2205	   9880	  53738	   d1ea	drivers/net/wireless/rndis_wlan.o.new

Changed functions rndis_set_oid and set_bssid to take const *'s.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/wireless/rndis_wlan.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index ee08bca..19f3d56 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -817,7 +817,8 @@ exit_unlock:
 	return ret;
 }
 
-static int rndis_set_oid(struct usbnet *dev, __le32 oid, void *data, int len)
+static int rndis_set_oid(struct usbnet *dev, __le32 oid, const void *data,
+			 int len)
 {
 	struct rndis_wlan_private *priv = get_rndis_wlan_priv(dev);
 	union {
@@ -1033,7 +1034,7 @@ static int set_essid(struct usbnet *usbdev, struct ndis_80211_ssid *ssid)
 	return ret;
 }
 
-static int set_bssid(struct usbnet *usbdev, u8 bssid[ETH_ALEN])
+static int set_bssid(struct usbnet *usbdev, const u8 *bssid)
 {
 	int ret;
 
@@ -1049,7 +1050,9 @@ static int set_bssid(struct usbnet *usbdev, u8 bssid[ETH_ALEN])
 
 static int clear_bssid(struct usbnet *usbdev)
 {
-	u8 broadcast_mac[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
+	static const u8 broadcast_mac[ETH_ALEN] = {
+		0xff, 0xff, 0xff, 0xff, 0xff, 0xff
+	};
 
 	return set_bssid(usbdev, broadcast_mac);
 }
-- 
1.7.3.2.245.g03276.dirty


  parent reply	other threads:[~2010-11-21  2:41 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-21  2:38 [PATCH 00/62] drivers/net: " Joe Perches
2010-11-21  2:38 ` [PATCH 01/62] 3c501: " Joe Perches
2010-11-21  2:38 ` [PATCH 02/62] 3c503: " Joe Perches
2010-11-21  2:38 ` [PATCH 03/62] 3c507: " Joe Perches
2010-11-21  2:38 ` [PATCH 04/62] 3c527: " Joe Perches
2010-11-21  2:38 ` [PATCH 05/62] at1700: " Joe Perches
2010-11-21  2:38 ` [PATCH 06/62] benet: " Joe Perches
2010-11-21  2:38 ` [PATCH 07/62] bnx2: " Joe Perches
2010-11-21  2:38 ` [PATCH 08/62] bnx2x: " Joe Perches
2010-11-21  2:38 ` [PATCH 09/62] can: " Joe Perches
2010-11-21  2:38 ` [PATCH 10/62] chelsio: " Joe Perches
2010-11-21  2:38 ` [PATCH 11/62] cxgb3: " Joe Perches
2010-11-21  2:38 ` [PATCH 12/62] " Joe Perches
2010-11-21  2:38 ` [PATCH 13/62] cxgb4: " Joe Perches
2010-11-21  2:38 ` [PATCH 14/62] cxgb4vf: " Joe Perches
2010-11-22 17:42   ` Casey Leedom
2010-11-21  2:38 ` [PATCH 15/62] e1000: " Joe Perches
2010-11-21  2:38 ` [PATCH 16/62] " Joe Perches
2010-11-21  2:38 ` [PATCH 17/62] e1000e: " Joe Perches
2010-11-21  2:38 ` [PATCH 18/62] e2100: " Joe Perches
2010-11-21  2:38 ` [PATCH 19/62] eepro: " Joe Perches
2010-11-21  2:38 ` [PATCH 20/62] eexpress: " Joe Perches
2010-11-21  2:38 ` [PATCH 21/62] gianfar: " Joe Perches
2010-11-21  2:38 ` [PATCH 22/62] hp: " Joe Perches
2010-11-21  2:38 ` [PATCH 23/62] igb: " Joe Perches
2010-11-21  2:38 ` [PATCH 24/62] irda: " Joe Perches
2010-11-21  2:38 ` [PATCH 25/62] " Joe Perches
2010-11-21  2:38 ` [PATCH 26/62] ixgbe: " Joe Perches
2010-11-21  2:38 ` [PATCH 27/62] ixgbevf: " Joe Perches
2010-11-21  2:38 ` [PATCH 28/62] ixgb: " Joe Perches
2010-11-21  2:38 ` [PATCH 29/62] jme: " Joe Perches
2010-11-21  2:38 ` [PATCH 30/62] ksz884x: " Joe Perches
2010-11-21  2:38 ` [PATCH 31/62] netxen: " Joe Perches
2010-11-21  2:38 ` [PATCH 32/62] ni52: " Joe Perches
2010-11-21  2:38 ` [PATCH 33/62] ni65: " Joe Perches
2010-11-21  2:38 ` [PATCH 34/62] pcmcia: " Joe Perches
2010-11-21  2:38 ` [PATCH 35/62] qlcnic: " Joe Perches
2010-11-21  2:38 ` [PATCH 36/62] qlge: " Joe Perches
2010-11-21  2:38 ` [PATCH 37/62] r8169: " Joe Perches
2010-11-21  2:38 ` [PATCH 38/62] s2io: " Joe Perches
2010-11-22  5:36   ` Jon Mason
2010-11-21  2:38 ` [PATCH 39/62] skfp: " Joe Perches
2010-11-21  2:38 ` [PATCH 40/62] skge: " Joe Perches
2010-11-21  2:38 ` [PATCH 41/62] smc-ultra: " Joe Perches
2010-11-21  2:38 ` [PATCH 42/62] tg3: " Joe Perches
2010-11-21  2:38 ` [PATCH 43/62] tokenring: " Joe Perches
2010-11-21  2:38 ` [PATCH 44/62] tulip: " Joe Perches
2010-11-21  2:38 ` [PATCH 45/62] " Joe Perches
2010-11-21  2:38 ` [PATCH 46/62] usb: " Joe Perches
2010-11-21 14:06   ` Sergei Shtylyov
2010-11-21  2:38 ` [PATCH 47/62] vmxnet3: " Joe Perches
2010-11-30 18:15   ` Shreyas Bhatewara
2010-11-30 18:24     ` David Miller
2010-11-30 18:36       ` Joe Perches
2010-11-21  2:38 ` [PATCH 48/62] wan: " Joe Perches
2010-11-21  2:38 ` [PATCH 49/62] wd: " Joe Perches
2010-11-21  2:38 ` [PATCH 50/62] ar9170: Use const Joe Perches
2010-11-21  2:38 ` [PATCH 51/62] ath5k: Use static const Joe Perches
2010-11-21  2:38 ` [PATCH 52/62] ath9k: " Joe Perches
2010-11-21  2:38 ` [PATCH 53/62] carl9170: " Joe Perches
2010-11-21  2:38 ` [PATCH 54/62] atmel: " Joe Perches
2010-11-21  2:38 ` [PATCH 55/62] b43: " Joe Perches
2010-11-21  2:38 ` [PATCH 56/62] iwlwifi: " Joe Perches
2010-11-22 15:37   ` Guy, Wey-Yi
2010-11-21  2:38 ` [PATCH 57/62] libertas: " Joe Perches
2010-11-21  2:38 ` [PATCH 58/62] ray_cs: " Joe Perches
2010-11-21  2:39 ` Joe Perches [this message]
2010-11-21  2:39 ` [PATCH 60/62] rt2x00: " Joe Perches
2010-11-21  8:58   ` Gertjan van Wingerde
2010-11-21  2:39 ` [PATCH 61/62] wl12xx: " Joe Perches
2010-11-21  2:39 ` [PATCH 62/62] zd1211rw: Use const Joe Perches
2010-11-21  4:50 ` [PATCH 00/62] drivers/net: Use static const David Miller
2010-11-22 22:10   ` Joe Perches
2010-11-22 22:19     ` David Miller
2010-11-22 22:40       ` Joe Perches
2010-11-23 16:28         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b953a3dc6bb044f9aee4033caeb1693ac0796fc.1290305776.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=jussi.kivilinna@mbnet.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®