From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752431AbdLCBLc (ORCPT ); Sat, 2 Dec 2017 20:11:32 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:41454 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbdLCBLa (ORCPT ); Sat, 2 Dec 2017 20:11:30 -0500 X-Google-Smtp-Source: AGs4zMY02x5KDDqy3kbVaHU9x2nGnJDuE2zWJ6rBRUs6O/1JglXYST8tmvXBdNRqIqKiIQD6kgG67Q== Subject: Re: [PATCH] iio: accel: bmc150: Add OF device ID table To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, Hartmut Knaack , Hans de Goede , linux-iio@vger.kernel.org, Lars-Peter Clausen , Peter Meerwald-Stadler References: <20171201111058.13483-1-javierm@redhat.com> <20171202120251.77ade310@archlinux> From: Javier Martinez Canillas Message-ID: <0b96ad0e-79b6-0f22-38e0-b4dc762621a5@redhat.com> Date: Sun, 3 Dec 2017 02:11:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171202120251.77ade310@archlinux> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jonathan, On 12/02/2017 01:02 PM, Jonathan Cameron wrote: > On Fri, 1 Dec 2017 12:10:58 +0100 > Javier Martinez Canillas wrote: > >> The driver doesn't have a struct of_device_id table but supported devices >> are registered via Device Trees. This is working on the assumption that a >> I2C device registered via OF will always match a legacy I2C device ID and >> that the MODALIAS reported will always be of the form i2c:. >> >> But this could change in the future so the correct approach is to have an >> OF device ID table if the devices are registered via OF. >> >> The I2C device ID table entries have the .driver_data field set, but they >> are not used in the driver so weren't set in the OF device table entries. >> >> Signed-off-by: Javier Martinez Canillas > > Applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to play with it. > > Would be nice to do the spi counterpart at somepoint, but as this is > clearly an improvement on nothing I applied this one as step 1. > Ok, I can do the same for SPI. I'll post a patch for it next week. > Good point about the data fields though - we should probably clean those > out as misleading. > Same for this, I can post a cleanup patch to get rid of the .data fields. > Thanks, > > Jonathan Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat