From: Matthias Brugger <matthias.bgg@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Rex-BC Chen <rex-bc.chen@mediatek.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] cpufreq: Avoid unnecessary frequency updates due to mismatch
Date: Thu, 5 May 2022 15:31:54 +0200 [thread overview]
Message-ID: <0b9e332d-f479-ed3d-78ce-6386383d827b@gmail.com> (raw)
In-Reply-To: <39e39a7d30c8ee6af81fb64670a330abeb87402e.1651652493.git.viresh.kumar@linaro.org>
On 04/05/2022 10:21, Viresh Kumar wrote:
> For some platforms, the frequency returned by hardware may be slightly
> different from what is provided in the frequency table. For example,
> hardware may return 499 MHz instead of 500 MHz. In such cases it is
> better to avoid getting into unnecessary frequency updates, as we may
> end up switching policy->cur between the two and sending unnecessary
> pre/post update notifications, etc.
>
> This patch has chosen allows the hardware frequency and table frequency
> to deviate by 1 MHz for now, we may want to increase it a bit later on
> if someone still complains.
>
> Reported-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/cpufreq/cpufreq.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 0d58b0f8f3af..233e8af48848 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -28,6 +28,7 @@
> #include <linux/suspend.h>
> #include <linux/syscore_ops.h>
> #include <linux/tick.h>
> +#include <linux/units.h>
> #include <trace/events/power.h>
>
> static LIST_HEAD(cpufreq_policy_list);
> @@ -1708,6 +1709,16 @@ static unsigned int cpufreq_verify_current_freq(struct cpufreq_policy *policy, b
> return new_freq;
>
> if (policy->cur != new_freq) {
> + /*
> + * For some platforms, the frequency returned by hardware may be
> + * slightly different from what is provided in the frequency
> + * table, for example hardware may return 499 MHz instead of 500
> + * MHz. In such cases it is better to avoid getting into
> + * unnecessary frequency updates.
> + */
> + if (abs(policy->cur - new_freq) < HZ_PER_MHZ)
> + return policy->cur;
> +
> cpufreq_out_of_sync(policy, new_freq);
> if (update)
> schedule_work(&policy->update);
next prev parent reply other threads:[~2022-05-05 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 8:21 Viresh Kumar
2022-05-04 12:06 ` Rex-BC Chen
2022-05-05 7:28 ` Vincent Guittot
2022-05-05 7:44 ` Viresh Kumar
2022-05-05 8:21 ` Vincent Guittot
2022-05-05 8:28 ` Viresh Kumar
2022-05-05 9:40 ` Vincent Guittot
2022-05-05 9:45 ` Viresh Kumar
2022-05-05 13:31 ` Matthias Brugger [this message]
2022-05-06 18:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b9e332d-f479-ed3d-78ce-6386383d827b@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rex-bc.chen@mediatek.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®