From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932785AbdBIVfK convert rfc822-to-8bit (ORCPT ); Thu, 9 Feb 2017 16:35:10 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:46040 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754395AbdBIVex (ORCPT ); Thu, 9 Feb 2017 16:34:53 -0500 From: Loic PALLARDY To: Bjorn Andersson CC: "ohad@wizery.com" , "lee.jones@linaro.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@stlinux.com" , Patrice CHOTARD , Hugues FRUCHET , "peter.griffin@linaro.org" Subject: RE: [PATCH v3 4/4] remoteproc: core: don't allocate carveout if pa or da are defined Thread-Topic: [PATCH v3 4/4] remoteproc: core: don't allocate carveout if pa or da are defined Thread-Index: AQHSe76g5SrY7v1IVkiQsRjq5W1qLaFf5s8AgAFZTgA= Date: Thu, 9 Feb 2017 21:34:13 +0000 Message-ID: <0ba1b913c5bb407195dc9b664992b707@SFHDAG7NODE2.st.com> References: <1485866156-6364-1-git-send-email-loic.pallardy@st.com> <1485866156-6364-5-git-send-email-loic.pallardy@st.com> <20170209015504.GM27837@minitux> In-Reply-To: <20170209015504.GM27837@minitux> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.48] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-09_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org] > Sent: Thursday, February 09, 2017 2:55 AM > To: Loic PALLARDY > Cc: ohad@wizery.com; lee.jones@linaro.org; linux- > remoteproc@vger.kernel.org; linux-kernel@vger.kernel.org; > kernel@stlinux.com; Patrice CHOTARD ; Hugues > FRUCHET ; peter.griffin@linaro.org > Subject: Re: [PATCH v3 4/4] remoteproc: core: don't allocate carveout if pa or > da are defined > > On Tue 31 Jan 04:35 PST 2017, Loic Pallardy wrote: > > > Remoteproc doesn't check if firmware requests fixed > > addresses for carveout regions. > > Current assumption is that platform specific driver is in > > charge of coprocessor specific memory region allocation and > > remoteproc core doesn't have to handle them. > > If a da or a pa is specified in firmware resource table, remoteproc > > core doesn't have to perform any allocation. > > Access to carveout will be done thanks to rproc_da_to_pa function, > > which will provide virtual address on carveout region allocated > > by platform specific driver. > > > > Signed-off-by: Loic Pallardy > > --- > > No change since V1 > > > > drivers/remoteproc/remoteproc_core.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/remoteproc/remoteproc_core.c > b/drivers/remoteproc/remoteproc_core.c > > index 90b05c7..dd63ceed 100644 > > --- a/drivers/remoteproc/remoteproc_core.c > > +++ b/drivers/remoteproc/remoteproc_core.c > > @@ -622,6 +622,11 @@ static int rproc_handle_carveout(struct rproc > *rproc, > > dev_dbg(dev, "carveout rsc: name: %s, da 0x%x, pa 0x%x, len 0x%x, > flags 0x%x\n", > > rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags); > > > > + if (rsc->pa != FW_RSC_ADDR_ANY || rsc->da != > FW_RSC_ADDR_ANY) { > > For devices with an IOMMU it's valid to specify "da" and have the > allocated region mapped there. So this is not correct. You're right, moreover patch series touch only to pa, so even if da behavior should be changed, should be done in a dedicated patch. I'll send a V4. Regards, Loic > > Regards, > Bjorn