From: shaozhengchao <shaozhengchao@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <davem@davemloft.net>, <edumazet@google.com>,
<pabeni@redhat.com>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net-next] net: sched: remove duplicate check of user rights in qdisc
Date: Fri, 19 Aug 2022 12:21:17 +0800 [thread overview]
Message-ID: <0ba453c4-6baa-7915-cf22-5953556e5b13@huawei.com> (raw)
In-Reply-To: <20220818204408.3fcb12a0@kernel.org>
On 2022/8/19 11:44, Jakub Kicinski wrote:
> On Thu, 18 Aug 2022 15:25:00 +0800 Zhengchao Shao wrote:
>> - if ((n->nlmsg_type != RTM_GETACTION) &&
>> - !netlink_capable(skb, CAP_NET_ADMIN))
>> - return -EPERM;
>
> This check is not network namespace capable, right?
>
> We're probably fine making it namespace aware but it needs to be a
> separate change.
Hi Jakub:
Thank you for your reply. I will add the wrong deletion back in V2. And
I will also consider to make checking namespace aware in action function.
Zhengchao Shao
prev parent reply other threads:[~2022-08-19 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 7:25 Zhengchao Shao
2022-08-19 3:44 ` Jakub Kicinski
2022-08-19 4:21 ` shaozhengchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ba453c4-6baa-7915-cf22-5953556e5b13@huawei.com \
--to=shaozhengchao@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®