From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CFCC43603 for ; Sat, 14 Dec 2019 12:30:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0AC320706 for ; Sat, 14 Dec 2019 12:30:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="OHETnmaE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726551AbfLNMas (ORCPT ); Sat, 14 Dec 2019 07:30:48 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:58533 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbfLNMar (ORCPT ); Sat, 14 Dec 2019 07:30:47 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576326647; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=nEhgWqsCxMZod3X8xArRbg45hp9WJhR8VXPah4HQGdA=; b=OHETnmaEmO1Fy0VxkkDuH1qJ0PaWp/9LYN36AhY9wASJwt2NDjB8yqLTwA+tZAZzpiNWmPLo NKpqX3Sw73thWVHY6Xp8R7fgWBKuIa0hCpibwctuO/DJQWovA6WbvbKqinMvLtXQR08fegmJ P3d3uXkB9K1NUsTy7IsaeSIe12A= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5df4d5f5.7f0a44f89a08-smtp-out-n02; Sat, 14 Dec 2019 12:30:45 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A22C1C447A3; Sat, 14 Dec 2019 12:30:45 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9749DC433CB; Sat, 14 Dec 2019 12:30:44 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 14 Dec 2019 20:30:44 +0800 From: cang@codeaurora.org To: Bjorn Andersson Cc: Avri Altman , asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Evan Green , Kishon Vijay Abraham I , Stephen Boyd , Stanley Chu , Vignesh Raghavendra , Bean Huo , Bart Van Assche , Venkat Gopalakrishnan , Tomas Winkler , Arnd Bergmann , open list Subject: Re: [PATCH v2 2/3] scsi: ufs: Modulize ufs-bsg In-Reply-To: <20191212182411.GE415177@yoga> References: <1576054123-16417-1-git-send-email-cang@codeaurora.org> <0101016ef425ef65-5c4508cc-5e76-4107-bb27-270f66acaa9a-000000@us-west-2.amazonses.com> <20191212045357.GA415177@yoga> <0101016ef8b2e2f8-72260b08-e6ad-42fc-bd4b-4a0a72c5c9b3-000000@us-west-2.amazonses.com> <20191212063703.GC415177@yoga> <0101016efb07efac-32cf270a-68dd-455a-b037-9fac2f3834cd-000000@us-west-2.amazonses.com> <20191212182411.GE415177@yoga> Message-ID: <0baa9d993cf9cb3e6c94f4c4440e9f95@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-12-13 02:24, Bjorn Andersson wrote: > On Thu 12 Dec 08:53 PST 2019, cang@codeaurora.org wrote: > >> On 2019-12-12 15:00, Avri Altman wrote: >> > > On Wed 11 Dec 22:01 PST 2019, cang@codeaurora.org wrote: >> > > > On 2019-12-12 12:53, Bjorn Andersson wrote: >> > > > > On Wed 11 Dec 00:49 PST 2019, Can Guo wrote: > [..] >> > > > And in real cases, as the UFS is the boot device, UFS driver will always >> > > > be probed during bootup. >> > > > >> > > >> > > The UFS driver will load and probe because it's mentioned in the >> > > devicetree, but if either the ufs drivers or any of its dependencies >> > > (phy, resets, clocks, etc) are built as modules it might very well >> > > finish probing after lateinitcall. >> > > >> > > So in the even that the bsg is =y and any of these drivers are =m, >> > > or if >> > > you're having bad luck with your timing, the list will be empty. >> > > >> > > As described below, if bsg=m, then there's nothing that will load the >> > > module and the bsg will not probe... >> > Right. >> > bsg=y and ufshcd=m is a bad idea, and should be avoided. >> > >> >> Yeah, I will get it addressed in the next patchset. >> > > If you build this around platform_device_register_data() from ufshcd I > don't see a reason to add additional restrictions on this combination > (even though it might not make much sense for people to use this > combination). > > Regards, > Bjorn Agree, thanks. Regards, Can Guo.