From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753370AbdKHVTh (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Nov 2017 16:19:37 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:46627 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752694AbdKHVTd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Nov 2017 16:19:33 -0500
Subject: Re: [PATCH] xen/pvcalls: remove redundant check for irq >= 0
To: Juergen Gross <jgross@suse.com>, Colin King <colin.king@canonical.com>,
        xen-devel@lists.xenproject.org
References: <20171103092047.28421-1-colin.king@canonical.com>
 <f9627c5a-c1b4-71b2-fba4-5cefa24c33ba@suse.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <0bb91134-e767-fa82-b45d-6c9ebb76e4b4@oracle.com>
Date: Wed, 8 Nov 2017 16:20:55 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <f9627c5a-c1b4-71b2-fba4-5cefa24c33ba@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/03/2017 06:01 AM, Juergen Gross wrote:
> On 03/11/17 10:20, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> This is a moot point, but irq is always less than zero at the label
>> out_error, so the check for irq >= 0 is redundant and can be removed.
>>
>> Detected by CoverityScan, CID#1460371 ("Logically dead code")
>>
>> Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>


Applied to for-linus-4.15.

-boris