From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31EA364A0; Fri, 16 Aug 2024 16:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723826058; cv=none; b=pwvI6cCgH5LsuZJ4HQUo8PSEorsN+Fv71Lp3ct+2zG7JqQEyTwuHHsZEPXPpeEr3tfw1G1KJlf49erdXk65bMOn1LkAFKKtMJsS71IAgpY7DbEBhDwG9ThXsOOfsk+VDbHzAdyn3O3ISU7mGGnAvUazR1le5lcb8jgbFsbe8N/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723826058; c=relaxed/simple; bh=EMxaGKEoQ5XNlozPQE68tVdZt5YficiAtbfARAv2tSA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=JVF+8/+wF2WTkfSCn48+M+jD2g47CjocA+VwXMrVAder/EJPi/PQertok5aF/W19zb7LoLzJGUmatUF4RJ//X7r0XDYDQ1WGvr42+J1WhLfjGdL0RxO/s9nYOZxLS1hoqzQiMFuQJUkqRw9hm0JfQ8vACEku89mfJXYFlaA0eno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bwnuBBKm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bwnuBBKm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77766C32782; Fri, 16 Aug 2024 16:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723826058; bh=EMxaGKEoQ5XNlozPQE68tVdZt5YficiAtbfARAv2tSA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=bwnuBBKmCd7Wr9YulPadaEHbJTQq1/irAgEwmqiMLMxQGYU26a8q0I4uzw1vNGzyH 6TgsXgL7iYz7oUpDWYoO2vdC0algO7V5j1Q6j3VnWF2TrhC5/ZgRY5ZZj85XkOu3ZW bRy98qYcTm5L7HAL/z9a49r1gJod6n7YeYMcoBmKrXClMIz0d01SiuW/sdig/jUSF8 NR9J/7jrcx4Kib/9RfhBofrDWnB8mrLQ+1AFrMeH+yeIMJxauKJnqPyrx7Tlxodp6J uijP0n+dkE+zo5gASPjinbXtgxK3Pnm/whwvH+sSNF3n4c1IMxx1yO0RUMc8HCys9s hMHzuoC0iZJuw== Message-ID: <0bc0bc150313d5cb91578f1b692bc62e066aa9e7.camel@kernel.org> Subject: Re: [PATCH 1/3] nfsd: bring in support for delstid draft XDR encoding From: Jeff Layton To: Chuck Lever Cc: Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , Tom Haynes , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Date: Fri, 16 Aug 2024 12:34:16 -0400 In-Reply-To: References: <20240816-delstid-v1-0-c221c3dc14cd@kernel.org> <20240816-delstid-v1-1-c221c3dc14cd@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2024-08-16 at 12:16 -0400, Chuck Lever wrote: > On Fri, Aug 16, 2024 at 11:45:32AM -0400, Jeff Layton wrote: > > On Fri, 2024-08-16 at 11:17 -0400, Chuck Lever wrote: > > > On Fri, Aug 16, 2024 at 08:42:07AM -0400, Jeff Layton wrote: > > > > This adds support for the "delstid" draft: > > > >=20 > > > > =C2=A0=C2=A0=C2=A0 > > > > https://datatracker.ietf.org/doc/draft-ietf-nfsv4-delstid/05/ > > > >=20 > > > > Most of this was autogenerated using Chuck's lkxdrgen tool with > > > > some > > > > by-hand tweaks to work around some symbol conflicts, and to add > > > > some > > > > missing pieces that were needed from nfs4_1.x. > > >=20 > > > I haven't read delstid closely enough to comment on the approach > > > you've taken in 3/3, but I do have some thoughts about code > > > organization here. I will try to study that draft soon. > > >=20 > > > And, I'm assuming you are continuing to evolve support for the > > > draft > > > and will be growing this series. So I will hold off on careful > > > inspection of 3/3 for the moment. > > >=20 > >=20 > > Yes. The client pieces are already in place, and I read I get is > > that > > the draft is all but done at this point. 3/3 is probably pretty > > close > > to what should go in. There are really 3 parts to the delstid > > draft: > >=20 > > 1/ the OPEN_XOR_DELEGATION part, which allows the server to avoid > > giving out an open stateid when giving out a deleg. > >=20 > > 2/ delegated timestamp support (which is the part I'm still looking > > at) > >=20 > > 3/ FATTR4_OPEN_ARGUMENTS (which enables 1 and 2) > >=20 > > This patchset encompasses 1 & 3. Part 2 shouldn't have much bearing > > on > > this set. It's really a separate feature entirely that just happens > > to > > also depend on FATTR4_OPEN_ARGUMENTS support. > >=20 > > > First, I'm pleased that you found xdrgen useful for rapid > > > prototyping. That's not something I had envisioned when I created > > > the tool, but it's a good match, looks like. > > >=20 > >=20 > > Yeah. It has some bugs that still need fixing, but it was certainly > > better than having to roll all of that by hand. >=20 > I'm very interested to hear bug reports. >=20 I should have been more diligent about collecting them! I'll do that soon. >=20 > > > Here you add a separate set of source files for delstid XDR...=C2=A0 > > > That > > > approach might not be scalable for adding subsequent new features > > > in > > > general, it occurs to me. > > >=20 > > > We might end up with a bunch of these little code blurbs with no > > > clear understanding of how they inter-relate.=C2=A0 Thoughts about ho= w > > > to > > > manage these are welcome: xdrgen could generate only header files > > > and then we would #include them where needed, for example. > > >=20 > > > For now, I suggest folding the new generated XDR code into the > > > existing NFSv4 "open" XDR code in fs/nfsd/nfs4xdr.c, when you > > > have > > > some time for cleaning up the patches. An alternative would be to > > > leave it and I can fold these together before committing. > > >=20 > > > (The long term, of course, will hopefully be generating all XDR > > > code > > > automatically, but we're a ways out from that, IMO). > > >=20 > >=20 > > This is where I disagree. > >=20 > > The nice thing about lkxdrgen is that most of what it generates is > > fairly self-contained. I think we ought to try to keep the new > > (mostly > > autogenerated) and old code (hand-rolled) separate for now. > >=20 > > I'm not sure what makes the most sense for a new naming scheme, but > > I > > really don't think we should paste all of this into nfs4xdr.c, > > which is > > just a huge jumble of hand-rolled XDR code.=20 >=20 > nfs4xdr.c is a mix of stuff that I constructed by rote, which is > pretty clean, and stuff that mixes the "just serialize" logic with > "do the proc part as well" logic, which is more ugly. I had thought > that OPEN's XDR was in the former category, but I get it.=20 >=20 > So I still think there's a scalability problem with adding each new > feature in its own XDR .c and .h, but I don't mind keeping the > generated code separate from the legacy code. How about creating one > new file to collect the mostly- or all-generated XDR code? >=20 > I've been using fs/nfsd/nfs[34]gen_xdr.[ch] in my testing. >=20 Sure, that sounds fine. I'll rename delstid_xdr.* to nfs4gen_xdr.*. --=20 Jeff Layton