From: Hans de Goede <hdegoede@redhat.com>
To: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>,
corentin.chary@gmail.com
Cc: ilpo.jarvinen@linux.intel.com, markgross@kernel.org,
acpi4asus-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-laptop: remove redundant braces in if statements
Date: Mon, 27 Nov 2023 13:25:53 +0100 [thread overview]
Message-ID: <0bc244e5-9c5c-4fd1-a545-32c22d717bf7@redhat.com> (raw)
In-Reply-To: <20231016191349.3856-1-edson.drosdeck@gmail.com>
Hi,
On 10/16/23 21:13, Edson Juliano Drosdeck wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/asus-laptop.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 761029f39314..bf03ea1b1274 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1816,9 +1816,8 @@ static void asus_dmi_check(void)
> return;
>
> /* On L1400B WLED control the sound card, don't mess with it ... */
> - if (strncmp(model, "L1400B", 6) == 0) {
> + if (strncmp(model, "L1400B", 6) == 0)
> wlan_status = -1;
> - }
> }
>
> static bool asus_device_present;
prev parent reply other threads:[~2023-11-27 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 19:13 Edson Juliano Drosdeck
2023-11-27 12:25 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc244e5-9c5c-4fd1-a545-32c22d717bf7@redhat.com \
--to=hdegoede@redhat.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=edson.drosdeck@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®