From: Haiyue Wang <haiyuewa@163.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-aspeed@lists.ozlabs.org
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Jammy Huang <jammy_huang@aspeedtech.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v1] media: aspeed: Fix driver probe failure
Date: Fri, 27 Feb 2026 23:18:13 +0800 [thread overview]
Message-ID: <0bc7875c-106c-48e1-8d40-72919ca227c4@163.com> (raw)
In-Reply-To: <8060fe77-18ec-4aa0-90a1-50eee398a55b@kernel.org>
On 2/27/2026 8:59 PM, Krzysztof Kozlowski wrote:
> On 27/02/2026 13:38, Haiyue Wang wrote:
>> The aspeed video (be compatible for ast2400, ast2500, ast2600) now needs
>> the reset DTS handle specified, otherwise it will fail to load:
>>
>> [ 0.000000] OF: reserved mem: initialized node video, compatible id shared-dma-pool
>> [ 0.000000] OF: reserved mem: 0xbb000000..0xbeffffff (65536 KiB) map reusable video
>> [ 0.377039] videodev: Linux video capture interface: v2.00
>> [ 4.809494] aspeed-video 1e700000.video: irq 57
>> [ 4.809977] aspeed-video 1e700000.video: Unable to get reset
>> [ 4.810341] aspeed-video 1e700000.video: probe with driver aspeed-video failed with error -2
>>
>> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
>> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
>> ---
>> arch/arm/boot/dts/aspeed/aspeed-g4.dtsi | 1 +
>> arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 1 +
>> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 1 +
>> include/dt-bindings/clock/ast2600-clock.h | 1 +
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
>
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
Seperated into two patches in v2, please help to review.
>> 4 files changed, 4 insertions(+)
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-02-27 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 12:38 Haiyue Wang
2026-02-27 12:59 ` Krzysztof Kozlowski
2026-02-27 15:18 ` Haiyue Wang [this message]
2026-02-27 15:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc7875c-106c-48e1-8d40-72919ca227c4@163.com \
--to=haiyuewa@163.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=jammy_huang@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®