From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C58A9C433FF for ; Mon, 5 Aug 2019 07:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A192120B1F for ; Mon, 5 Aug 2019 07:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727546AbfHEH3Y (ORCPT ); Mon, 5 Aug 2019 03:29:24 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:53154 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726423AbfHEH3Y (ORCPT ); Mon, 5 Aug 2019 03:29:24 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C55FD1E40EC70E83D1C0; Mon, 5 Aug 2019 15:29:20 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 5 Aug 2019 15:29:11 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: remove duplicate code in f2fs_file_write_iter To: Lihong Kou , CC: , , , References: <1564990044-107117-1-git-send-email-koulihong@huawei.com> From: Chao Yu Message-ID: <0bcef312-96b0-4630-6001-e3e2fe102e71@huawei.com> Date: Mon, 5 Aug 2019 15:29:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1564990044-107117-1-git-send-email-koulihong@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/8/5 15:27, Lihong Kou wrote: > We will do the same check in generic_write_checks. > if (iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT) > return -EINVAL; > just remove the same check in f2fs_file_write_iter. > > Signed-off-by: Lihong Kou Reviewed-by: Chao Yu Thanks,