From: Joe Perches <joe@perches.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@beagleboard.org>
Subject: Re: [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files
Date: Wed, 10 Feb 2021 15:12:39 -0800 [thread overview]
Message-ID: <0bd0286b12832bdbe815325f581aec3a8ae3ca2d.camel@perches.com> (raw)
In-Reply-To: <20210210212115.GA216435@x1>
On Wed, 2021-02-10 at 13:21 -0800, Drew Fustini wrote:
> I will change from the incorrect 0400 to 0444.
Thanks.
> As for S_IFREG, it does seem like leaving off S_IFREG is the most common
> case when using octal permissions with debugfs_create_*():
>
> $ git grep debugfs_create drivers/ |grep 0444 |grep -v S_IFREG | wc -l
> 302
> $ git grep debugfs_create drivers/ |grep 0444 |grep S_IFREG | wc -l
> 9
It's ~2:1 when using S_IRUGO
$ git grep debugfs_create_file drivers/ | grep S_IRUGO | grep -v S_IFREG | wc -l
109
$ git grep debugfs_create_file drivers/ | grep S_IRUGO | grep S_IFREG | wc -l
48
next prev parent reply other threads:[~2021-02-10 23:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 7:49 [PATCH v2 0/2] pinctrl: pinmux: Add pinmux-select debugfs file Drew Fustini
2021-02-10 7:49 ` [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files Drew Fustini
2021-02-10 8:30 ` Joe Perches
2021-02-10 10:18 ` Andy Shevchenko
2021-02-10 12:36 ` Joe Perches
2021-02-10 21:21 ` Drew Fustini
2021-02-10 23:12 ` Joe Perches [this message]
2021-02-10 8:31 ` Geert Uytterhoeven
2021-02-10 10:14 ` Andy Shevchenko
2021-02-10 10:16 ` Andy Shevchenko
2021-02-10 7:49 ` [PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file Drew Fustini
2021-02-10 8:35 ` Geert Uytterhoeven
2021-02-10 9:56 ` Andy Shevchenko
2021-02-10 17:31 ` Drew Fustini
2021-02-10 18:20 ` Dan Carpenter
2021-02-10 18:39 ` Geert Uytterhoeven
2021-02-10 19:05 ` Dan Carpenter
2021-02-10 19:14 ` Drew Fustini
2021-02-10 19:04 ` Drew Fustini
2021-02-10 20:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bd0286b12832bdbe815325f581aec3a8ae3ca2d.camel@perches.com \
--to=joe@perches.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andy.shevchenko@gmail.com \
--cc=drew@beagleboard.org \
--cc=geert@linux-m68k.org \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robertcnelson@beagleboard.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®