From: Shawn Lin <shawn.lin@rock-chips.com>
To: hehuan1@eswincomputing.com
Cc: shawn.lin@rock-chips.com, ningyu@eswincomputing.com,
linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com,
xuxiang@eswincomputing.com, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
ulf.hansson@linaro.org
Subject: Re: [PATCH v1] mmc: sdhci-of-dwcmshc: fix init for AXI clock and DMA 128MB boundary
Date: Fri, 9 Jan 2026 15:03:15 +0800 [thread overview]
Message-ID: <0bd26d36-04da-4139-84fd-d62a5cb3f6a0@rock-chips.com> (raw)
In-Reply-To: <20260109032810.204-1-hehuan1@eswincomputing.com>
在 2026/01/09 星期五 11:28, hehuan1@eswincomputing.com 写道:
> From: Huan He <hehuan1@eswincomputing.com>
>
> 1.Accessing the High-Speed registers requires the AXI clock to be enabled.
> 2.This DWC MSHC has a 128MB limitation where the data buffer size and
> start address must not exceed the 128MB boundary. Registering the
> missing 'adma_write_desc' callback function.
>
This looks like you should split it into two patches with
proper Fixes tags.
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>
> ---
> drivers/mmc/host/sdhci-of-dwcmshc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 51949cde0958..147f8046707f 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -1588,6 +1588,7 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcm
> {
> u32 emmc_caps = MMC_CAP2_NO_SD | MMC_CAP2_NO_SDIO;
> unsigned int val, hsp_int_status, hsp_pwr_ctrl;
> + static const char * const clk_ids[] = {"axi"};
> struct of_phandle_args args;
> struct eic7700_priv *priv;
> struct regmap *hsp_regmap;
> @@ -1605,6 +1606,11 @@ static int eic7700_init(struct device *dev, struct sdhci_host *host, struct dwcm
> return ret;
> }
>
> + ret = dwcmshc_get_enable_other_clks(mmc_dev(host->mmc), dwc_priv,
> + ARRAY_SIZE(clk_ids), clk_ids);
> + if (ret)
> + return ret;
> +
> ret = of_parse_phandle_with_fixed_args(dev->of_node, "eswin,hsp-sp-csr", 2, 0, &args);
> if (ret) {
> dev_err(dev, "Fail to parse 'eswin,hsp-sp-csr' phandle (%d)\n", ret);
> @@ -1726,6 +1732,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = {
> .set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper,
> .set_power = sdhci_set_power_and_bus_voltage,
> .irq = dwcmshc_cqe_irq_handler,
> + .adma_write_desc = dwcmshc_adma_write_desc,
> .platform_execute_tuning = sdhci_eic7700_executing_tuning,
> };
>
next prev parent reply other threads:[~2026-01-09 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 3:28 hehuan1
2026-01-09 7:03 ` Shawn Lin [this message]
2026-01-09 7:36 ` Krzysztof Kozlowski
2026-01-09 8:35 ` Huan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bd26d36-04da-4139-84fd-d62a5cb3f6a0@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=adrian.hunter@intel.com \
--cc=hehuan1@eswincomputing.com \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=pinkesh.vaghela@einfochips.com \
--cc=ulf.hansson@linaro.org \
--cc=xuxiang@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®