From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E17AC432C0 for ; Wed, 20 Nov 2019 14:43:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6372121826 for ; Wed, 20 Nov 2019 14:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731796AbfKTOn1 (ORCPT ); Wed, 20 Nov 2019 09:43:27 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:2109 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728483AbfKTOn0 (ORCPT ); Wed, 20 Nov 2019 09:43:26 -0500 Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 722B3211A0E7082DDAF9; Wed, 20 Nov 2019 14:43:24 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by LHREML714-CAH.china.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Nov 2019 14:43:23 +0000 Received: from [127.0.0.1] (10.202.226.46) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 20 Nov 2019 14:43:23 +0000 Subject: Re: [PATCH] scsi: Fix Kconfig indentation To: Krzysztof Kozlowski , "linux-kernel@vger.kernel.org" CC: "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , "QLogic-Storage-Upstream@cavium.com" , Don Brace , "linux-scsi@vger.kernel.org" , "esc.storagedev@microsemi.com" References: <20191120133935.13823-1-krzk@kernel.org> From: John Garry Message-ID: <0bd60062-8019-646f-0e63-66b31b272d00@huawei.com> Date: Wed, 20 Nov 2019 14:43:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191120133935.13823-1-krzk@kernel.org> Content-Type: text/plain; charset="gbk"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.46] X-ClientProxiedBy: lhreml720-chm.china.huawei.com (10.201.108.71) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/11/2019 13:39, Krzysztof Kozlowski wrote: > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style with command like: > $ sed -e 's/^ /\t/' -i */Kconfig > ./scripts/checkpatch.pl -f --strict drivers/scsi/Kconfig didn't warn of indentation issues for me. To stop this reoccurring, could that be added? Thanks, John > Signed-off-by: Krzysztof Kozlowski > --- > drivers/scsi/Kconfig | 22 +++++++++++----------- > drivers/scsi/aic7xxx/Kconfig.aic7xxx | 14 +++++++------- > drivers/scsi/pcmcia/Kconfig | 2 +- > drivers/scsi/qedf/Kconfig | 4 ++-- > drivers/scsi/smartpqi/Kconfig | 8 ++++---- > 5 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index 90cf4691b8c3..de6b99573f9e 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -1166,8 +1166,8 @@ config SCSI_LPFC > depends on NVME_FC || NVME_FC=n > select CRC_T10DIF > ---help--- > - This lpfc driver supports the Emulex LightPulse > - Family of Fibre Channel PCI host adapters. > + This lpfc driver supports the Emulex LightPulse > + Family of Fibre Channel PCI host adapters. > > config SCSI_LPFC_DEBUG_FS > bool "Emulex LightPulse Fibre Channel debugfs Support" > @@ -1480,14 +1480,14 @@ config ZFCP > depends on S390 && QDIO && SCSI > depends on SCSI_FC_ATTRS > help > - If you want to access SCSI devices attached to your IBM eServer > - zSeries by means of Fibre Channel interfaces say Y. > - For details please refer to the documentation provided by IBM at > - > + If you want to access SCSI devices attached to your IBM eServer > + zSeries by means of Fibre Channel interfaces say Y. > + For details please refer to the documentation provided by IBM at > + > > - This driver is also available as a module. This module will be > - called zfcp. If you want to compile it as a module, say M here > - and read . > + This driver is also available as a module. This module will be > + called zfcp. If you want to compile it as a module, say M here > + and read . > > config SCSI_PMCRAID > tristate "PMC SIERRA Linux MaxRAID adapter support" > @@ -1518,8 +1518,8 @@ config SCSI_VIRTIO > tristate "virtio-scsi support" > depends on VIRTIO > help > - This is the virtual HBA driver for virtio. If the kernel will > - be used in a virtual machine, say Y or M. > + This is the virtual HBA driver for virtio. If the kernel will > + be used in a virtual machine, say Y or M. > > source "drivers/scsi/csiostor/Kconfig" > > diff --git a/drivers/scsi/aic7xxx/Kconfig.aic7xxx b/drivers/scsi/aic7xxx/Kconfig.aic7xxx > index 3546b8cc401f..4ed44ba4a55b 100644 > --- a/drivers/scsi/aic7xxx/Kconfig.aic7xxx > +++ b/drivers/scsi/aic7xxx/Kconfig.aic7xxx > @@ -71,20 +71,20 @@ config AIC7XXX_DEBUG_ENABLE > driver errors. > > config AIC7XXX_DEBUG_MASK > - int "Debug code enable mask (2047 for all debugging)" > - depends on SCSI_AIC7XXX > - default "0" > - help > + int "Debug code enable mask (2047 for all debugging)" > + depends on SCSI_AIC7XXX > + default "0" > + help > Bit mask of debug options that is only valid if the > CONFIG_AIC7XXX_DEBUG_ENABLE option is enabled. The bits in this mask > are defined in the drivers/scsi/aic7xxx/aic7xxx.h - search for the > variable ahc_debug in that file to find them. > > config AIC7XXX_REG_PRETTY_PRINT > - bool "Decode registers during diagnostics" > - depends on SCSI_AIC7XXX > + bool "Decode registers during diagnostics" > + depends on SCSI_AIC7XXX > default y > - help > + help > Compile in register value tables for the output of expanded register > contents in diagnostics. This make it much easier to understand debug > output without having to refer to a data book and/or the aic7xxx.reg > diff --git a/drivers/scsi/pcmcia/Kconfig b/drivers/scsi/pcmcia/Kconfig > index dc9b74c9348a..a7920fc95e7d 100644 > --- a/drivers/scsi/pcmcia/Kconfig > +++ b/drivers/scsi/pcmcia/Kconfig > @@ -56,7 +56,7 @@ config PCMCIA_NINJA_SCSI > [I-O DATA (OEM) (version string: "IO DATA","CBSC16 ","1")] > I-O DATA CBSC-II > [Kyusyu Matsushita Kotobuki (OEM) > - (version string: "KME ","SCSI-CARD-001","1")] > + (version string: "KME ","SCSI-CARD-001","1")] > KME KXL-820AN's card > HP M820e CDRW's card > etc. > diff --git a/drivers/scsi/qedf/Kconfig b/drivers/scsi/qedf/Kconfig > index 7cd993be4e57..80328dbd44c9 100644 > --- a/drivers/scsi/qedf/Kconfig > +++ b/drivers/scsi/qedf/Kconfig > @@ -3,8 +3,8 @@ config QEDF > tristate "QLogic QEDF 25/40/100Gb FCoE Initiator Driver Support" > depends on PCI && SCSI > depends on QED > - depends on LIBFC > - depends on LIBFCOE > + depends on LIBFC > + depends on LIBFCOE > select QED_LL2 > select QED_FCOE > ---help--- > diff --git a/drivers/scsi/smartpqi/Kconfig b/drivers/scsi/smartpqi/Kconfig > index bc6506884e3b..456ec474fa17 100644 > --- a/drivers/scsi/smartpqi/Kconfig > +++ b/drivers/scsi/smartpqi/Kconfig > @@ -50,7 +50,7 @@ config SCSI_SMARTPQI > To compile this driver as a module, choose M here: the > module will be called smartpqi. > > - Note: the aacraid driver will not manage a smartpqi > - controller. You need to enable smartpqi for smartpqi > - controllers. For more information, please see > - Documentation/scsi/smartpqi.txt > + Note: the aacraid driver will not manage a smartpqi > + controller. You need to enable smartpqi for smartpqi > + controllers. For more information, please see > + Documentation/scsi/smartpqi.txt >