mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: maobibo <maobibo@loongson.cn>
To: WANG Xuerui <kernel@xen0n.name>,
	Huacai Chen <chenhuacai@kernel.org>,
	Tianrui Zhao <zhaotianrui@loongson.cn>,
	Juergen Gross <jgross@suse.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
	virtualization@lists.linux.dev, kvm@vger.kernel.org
Subject: Re: [PATCH v7 7/7] Documentation: KVM: Add hypercall for LoongArch
Date: Tue, 2 Apr 2024 09:15:51 +0800	[thread overview]
Message-ID: <0bdcaf41-c54d-9f39-0dd2-3b3d2a954649@loongson.cn> (raw)
In-Reply-To: <68473508-dbf1-4875-a392-88ca09f7ea63@xen0n.name>



On 2024/3/24 上午2:40, WANG Xuerui wrote:
> On 3/15/24 16:11, Bibo Mao wrote:
>> [snip]
>> +KVM hypercall ABI
>> +=================
>> +
>> +Hypercall ABI on KVM is simple, only one scratch register a0 and at most
>> +five generic registers used as input parameter. FP register and 
>> vector register
>> +is not used for input register and should not be modified during 
>> hypercall.
>> +Hypercall function can be inlined since there is only one scratch 
>> register.
> 
> Maybe it's better to describe the list of preserved registers with an 
> expression such as "all non-GPR registers shall remain unmodified after 
> returning from the hypercall", to guard ourselves against future ISA 
> state additions.
Sorry, I do not understand. What is the meaning of "all non-GPR 
registers"?  Can you give an example?

Regards
Bibo Mao
> 
> But I still maintain that it's better to promise less here, and only 
> hint on the extensive preservation of context as an implementation 
> detail. It is for not losing our ability to save/restore less in the 
> future, should we decide to do so.
> 


      reply	other threads:[~2024-04-02  1:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15  8:07 [PATCH v7 0/7] LoongArch: Add pv ipi support on LoongArch VM Bibo Mao
2024-03-15  8:07 ` [PATCH v7 1/7] LoongArch/smp: Refine some ipi functions on LoongArch platform Bibo Mao
2024-03-15  8:07 ` [PATCH v7 2/7] LoongArch: KVM: Add hypercall instruction emulation support Bibo Mao
2024-03-15  8:07 ` [PATCH v7 3/7] LoongArch: KVM: Add cpucfg area for kvm hypervisor Bibo Mao
2024-03-23 19:02   ` WANG Xuerui
2024-04-02  1:43     ` maobibo
2024-04-02  2:49       ` Xi Ruoyao
2024-04-02  3:04         ` maobibo
2024-04-02  3:34         ` maobibo
2024-04-02  5:34           ` Xi Ruoyao
2024-03-15  8:07 ` [PATCH v7 4/7] LoongArch: KVM: Add vcpu search support from physical cpuid Bibo Mao
2024-03-15  8:07 ` [PATCH v7 5/7] LoongArch: KVM: Add pv ipi support on kvm side Bibo Mao
2024-03-15  8:10 ` [PATCH v7 6/7] LoongArch: Add pv ipi support on guest kernel side Bibo Mao
2024-03-15  8:11 ` [PATCH v7 7/7] Documentation: KVM: Add hypercall for LoongArch Bibo Mao
2024-03-23 18:40   ` WANG Xuerui
2024-04-02  1:15     ` maobibo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bdcaf41-c54d-9f39-0dd2-3b3d2a954649@loongson.cn \
    --to=maobibo@loongson.cn \
    --cc=chenhuacai@kernel.org \
    --cc=corbet@lwn.net \
    --cc=jgross@suse.com \
    --cc=kernel@xen0n.name \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=zhaotianrui@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®