From: James Clark <james.clark@linaro.org>
To: Leo Yan <leo.yan@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Leo Yan <leo.yan@linux.dev>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@arm.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf cs-etm: Finish removal of ETM_OPT_*
Date: Fri, 6 Mar 2026 13:01:24 +0000 [thread overview]
Message-ID: <0be8ed2c-9305-49e6-a315-bdfc15af70d6@linaro.org> (raw)
In-Reply-To: <20260306122729.GL1098637@e132581.arm.com>
On 06/03/2026 12:27 pm, Leo Yan wrote:
> On Fri, Mar 06, 2026 at 11:24:45AM +0000, Coresight ML wrote:
>
> [...]
>
>> -static int cs_etm__setup_timeless_decoding(struct cs_etm_auxtrace *etm)
>> +static void cs_etm__setup_timeless_decoding(struct cs_etm_auxtrace *etm,
>> + u64 *metadata)
>
> nitpick: here it can avoid a new argument "metadata", directly retrieve
> from etm->metadata[0]. Otherwise, LGTM.
Oh yeah, I thought it wasn't assigned yet but it is.
next prev parent reply other threads:[~2026-03-06 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 11:24 [PATCH 0/2] " James Clark
2026-03-06 11:24 ` [PATCH 1/2] " James Clark
2026-03-06 12:27 ` Leo Yan
2026-03-06 13:01 ` James Clark [this message]
2026-03-06 11:24 ` [PATCH 2/2] tools: Sync coresight-pmu.h header James Clark
2026-03-06 12:28 ` [PATCH 0/2] perf cs-etm: Finish removal of ETM_OPT_* Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0be8ed2c-9305-49e6-a315-bdfc15af70d6@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®