From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751800AbdGaF4K (ORCPT <rfc822;w@1wt.eu>);
        Mon, 31 Jul 2017 01:56:10 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:59623 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751264AbdGaF4H (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 31 Jul 2017 01:56:07 -0400
Subject: Re: [PATCH 12/12] mmc: bcm2835: constify mmc_host_ops structures
To: Julia Lawall <Julia.Lawall@lip6.fr>,
        Ulf Hansson <ulf.hansson@linaro.org>
Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com, Eric Anholt <eric@anholt.net>,
        linux-mmc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <1501307981-29745-1-git-send-email-Julia.Lawall@lip6.fr>
 <1501307981-29745-13-git-send-email-Julia.Lawall@lip6.fr>
From: Stefan Wahren <stefan.wahren@i2se.com>
Message-ID: <0beb2ef0-0a2d-5289-2956-af106d092cf6@i2se.com>
Date: Mon, 31 Jul 2017 07:55:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1501307981-29745-13-git-send-email-Julia.Lawall@lip6.fr>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: de-DE
X-Provags-ID: V03:K0:PahuixrLV6pTcIOJ2weJcR29JKxByL2ZBDExmp/QDYQVeeEhqa0
 Wkd0MgfKzGE7fNp2p0EcghMkUfuja86ZC6pBGu4ddrLFdY2kJSz3J+iuPZq8lbMPSO6RhWp
 DR6P8UUaTC6pwQGKDJnCUzg6VEfHe3nfPvPuWH3EhNwyPx7yj9EgMPjn7uk5WrGkE/KDyQJ
 QsJ+TTC0SEYOn+mGSSHUg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:K7hka9OYij0=:r5m5wV2XQYV+JJe97mQlAE
 kJpyynOxqLDn8UvU39ND+ljD+NU0Xz/fukf28kQ8NNm4eijXHv9BCAPh3EohO0lD0DbZooA3l
 EXU5w2Xk8zuckpcwxQQ2sSf6sovioDcebV9BBmBZB+CCUoAin/h9519UHmbnoyvCa+vJ+08B4
 7N0oB+q6YMl5ao32pOVmMbqmrMCTUDLF3ZhC0SIwBj5MALjbz6eou3Q1/BVQSGXJrDaIB2Zj6
 hL3fRZ3SmtM76m1SHMQCTY/x8pDiPv9RtoVJrpXRejhr23vjlKm6GrVsNWLwXVh77+SUabqkj
 ccgZstdE3FtizqIMAamNzw96gNABlkHlK4Ar8lkNbeBXMKLHc491rwNZYNutI2G4SzXo/+lsj
 78/cPVMcHAQoOgxr9nl34xgwxUi7NM463qDgCmfyg90OYuqYy1aKTQldyjphWezjEHMkhqe1T
 jWRu17ihEYWS/rNZYgX3ZGbmxb5BFEgq7412+Ak5qMpiSG7n434pIcT/RTDkUrmmPPMzUfNGU
 Dtki4XZUwV/kJEbRra87mz1IEQ7xbFd3IRhowRFPc3CpCmELntRFaTRfwvCJBxe8GyZm3neG+
 atZXwe0+4pgU9GNW2eEhBqiwTrNEnOFqMk3/eZSV+kMtKt2OXVvFFhmNLjxCCwvPM27W9fA6J
 C/PYa0gdT5jURoqEKF59vFRy3tTJ0xEvIBtXthyEj4q7UINcDfOLaWA5tPEPUZB9F/EFsBUwE
 gOq63iHL8Xc3f+sKGutiPfZb38C2my0MNWYGtwkowKouCV/lcEqGCd6hLwU=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 29.07.2017 um 07:59 schrieb Julia Lawall:
> The mmc_host_ops structure is only stored in the ops field of an
> mmc_host structure, which is declared as const.  Thus the mmc_host_ops
> structure itself can be const.
>
> Done with the help of Coccinelle.
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct mmc_host_ops i@p = { ... };
>
> @ok1@
> struct mmc_host *mmc;
> identifier r.i;
> position p;
> @@
> mmc->ops = &i@p
>
> @bad@
> position p != {r.p,ok1.p};
> identifier r.i;
> struct mmc_host_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct mmc_host_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>