From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 547A2CA9EC5 for ; Wed, 30 Oct 2019 09:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D1672054F for ; Wed, 30 Oct 2019 09:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726222AbfJ3Jq1 (ORCPT ); Wed, 30 Oct 2019 05:46:27 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:63202 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbfJ3Jq0 (ORCPT ); Wed, 30 Oct 2019 05:46:26 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x9U9dxJn067273 for ; Wed, 30 Oct 2019 05:46:25 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2vy7dkst4r-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 30 Oct 2019 05:46:25 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Oct 2019 09:46:22 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 30 Oct 2019 09:46:18 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x9U9kHmP54263846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Oct 2019 09:46:17 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA6A4A4040; Wed, 30 Oct 2019 09:46:16 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F3C12A404D; Wed, 30 Oct 2019 09:46:11 +0000 (GMT) Received: from [9.199.50.60] (unknown [9.199.50.60]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 30 Oct 2019 09:46:11 +0000 (GMT) Subject: Re: [PATCH] perf script: Fix obtaining next event To: Chandan Rajendra , acme@kernel.org Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, rostedt@goodmis.org, tstoyanov@vmware.com, gregkh@linuxfoundation.org, kstewart@linuxfoundation.org, tglx@linutronix.de, chandan@linux.ibm.com, Ravi Bangoria References: <20191030084032.31503-1-chandanrlinux@gmail.com> From: Ravi Bangoria Date: Wed, 30 Oct 2019 15:16:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191030084032.31503-1-chandanrlinux@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19103009-0028-0000-0000-000003B10C27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19103009-0029-0000-0000-000024735046 Message-Id: <0befd460-b9bf-ba2b-556a-aa06798b16b9@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-30_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910300095 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/19 2:10 PM, Chandan Rajendra wrote: > The current code segfaults when perf.data file contains two or more > events. This happens due to incorrect pointer arithmetic being performed > in trace_find_next_event(). > > tep_handle->events is an array of pointers to 'struct tep_event'. The > pointer arithmetic interprets tep_handle->events as an array of 'struct > tep_event' elements. > > This commit replaces the usage of pointer arithmetic with calls to > tep_get_event(). > > Fixes: bb3dd7e ("tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file") > Signed-off-by: Chandan Rajendra $ sudo ./perf record -e sched:sched_switch -e syscalls:sys_enter_openat -- make Without patch: $ sudo ./perf script -g python Segmentation fault With patch: $ sudo ./perf script -g python generated Python script: perf-script.py Reviewed-and-tested-by: Ravi Bangoria