From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
<amadeuszx.slawinski@linux.intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
<nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
<netdev@vger.kernel.org>, Markus Elfring <Markus.Elfring@web.de>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [RFC PATCH v2] Simply enable one to write code like:
Date: Wed, 2 Oct 2024 10:07:33 +0200 [thread overview]
Message-ID: <0bf84a9c-f274-4b92-8545-7e1418c00ffa@intel.com> (raw)
In-Reply-To: <ZvwQjMwdDVviQL2P@smile.fi.intel.com>
On 10/1/24 17:09, Andy Shevchenko wrote:
> On Tue, Oct 01, 2024 at 04:57:18PM +0200, Przemek Kitszel wrote:
>
> ...
>
>> NAKed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> And still NAKed.
>
>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>> ---
>> Andy believes that this change is completely wrong C, the reasons
>> (that I disagree with of course, are in v1, below the commit message).
>
> Have you retested the macro expansion for this version?
yeah, I basically work with the expanded version, still linear
expansion, just ~dozen bytes more than v1
>
> ...
>
>> */
>>
>> +
>
> Too many blank lines.
thanks!
>
>> +#define DEFINE_CLASS_IS_CONDITIONAL(_name, _is_cond) \
>> +static __maybe_unused const bool class_##_name##_is_conditional = _is_cond
>
> ...
>
>> + DEFINE_CLASS_IS_CONDITIONAL(_name, 0); \
>
> Here and everywhere else, boolean has values true and false.
sure, thanks
next prev parent reply other threads:[~2024-10-02 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 14:57 Przemek Kitszel
2024-10-01 15:09 ` Andy Shevchenko
2024-10-02 8:07 ` Przemek Kitszel [this message]
2024-10-01 15:21 ` Dmitry Torokhov
2024-10-02 9:55 ` Przemek Kitszel
2024-10-01 15:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bf84a9c-f274-4b92-8545-7e1418c00ffa@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=Markus.Elfring@web.de \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®