mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: kuba@kernel.org, hayeswang@realtek.com, edumazet@google.com
Cc: LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, davem@davemloft.net,
	linux-usb@vger.kernel.org, pabeni@redhat.com,
	Paul Menzel <pmenzel@molgen.mpg.de>
Subject: Error 'netif_napi_add_weight() called with weight 256'
Date: Mon, 31 Jul 2023 11:02:40 -0500	[thread overview]
Message-ID: <0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com> (raw)

Hi,

I noticed today with 6.5-rc4 and also on 6.1.42 that I'm getting an 
error from an r8152 based dongle (Framework ethernet expansion card).

netif_napi_add_weight() called with weight 256

It seems that this message is likely introduced by
8ded532cd1cbe ("r8152: switch to netif_napi_add_weight()")

which if the card has support_2500full set will program the value to 256:

	netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
			      tp->support_2500full ? 256 : 64);

It's err level from
82dc3c63c692b ("net: introduce NAPI_POLL_WEIGHT")

Why is this considered an error but the driver uses the bigger value?
Should it be downgraded to a warning?

Thanks,

             reply	other threads:[~2023-07-31 16:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31 16:02 Limonciello, Mario [this message]
2023-07-31 18:13 ` Jakub Kicinski
2023-07-31 18:23   ` Limonciello, Mario
2023-07-31 20:47     ` Stephen Hemminger
2023-08-07  9:57     ` Hayes Wang
2023-08-07 16:37       ` Jakub Kicinski
2023-08-09 13:11         ` Hayes Wang
2023-08-09 18:37           ` Jakub Kicinski
2023-08-14  7:07             ` Hayes Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hayeswang@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®