From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>, Stefan Wahren <wahrenst@gmx.net>,
Philipp Zabel <p.zabel@pengutronix.de>,
USB <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
tim.gover@raspberrypi.org, linux-pci <linux-pci@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v4 6/9] Revert "USB: pci-quirks: Add Raspberry Pi 4 quirk"
Date: Mon, 22 Jun 2020 17:11:47 +0200 [thread overview]
Message-ID: <0c0546cfe855eee1381c629b2ffd7f65427c7091.camel@suse.de> (raw)
In-Reply-To: <CAHp75Vcpo49BUe+cApfbB2BXFLz0SyLjWkO_6Uw=sYEcJEBMPg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
Hi Andy,
On Mon, 2020-06-22 at 17:44 +0300, Andy Shevchenko wrote:
> On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne
> <nsaenzjulienne@suse.de> wrote:
> > This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc.
> >
> > The initialization of Raspberry Pi 4's USB chip is now handled through a
> > reset controller. No need to directly call the firmware routine trough a
>
> trough -> through.
>
> > pci quirk.
>
> pci -> PCI.
>
Noted
> ...
>
> > -
> > -#include <soc/bcm2835/raspberrypi-firmware.h>
> > -
>
> Leave one blank line here.
This being a revert, does it make sense to do so? If we are 100% strict about
it, the space should come from a separate patch.
That said, if you insist I'll be happy to edit it.
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-22 15:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 10:38 [PATCH v4 0/9] Raspberry Pi 4 USB firmware initialization rework Nicolas Saenz Julienne
2020-06-22 10:38 ` [PATCH v4 1/9] dt-bindings: reset: Add a binding for the RPi Firmware reset controller Nicolas Saenz Julienne
2020-06-22 10:38 ` [PATCH v4 2/9] reset: Add Raspberry Pi 4 firmware " Nicolas Saenz Julienne
2020-06-22 14:42 ` Andy Shevchenko
2020-06-22 15:08 ` Nicolas Saenz Julienne
2020-06-22 15:48 ` Andy Shevchenko
2020-06-22 10:38 ` [PATCH v4 3/9] ARM: dts: bcm2711: Add firmware usb reset node Nicolas Saenz Julienne
2020-06-22 10:38 ` [PATCH v4 4/9] ARM: dts: bcm2711: Add reset controller to xHCI node Nicolas Saenz Julienne
2020-06-22 10:38 ` [PATCH v4 5/9] usb: xhci-pci: Add support for reset controllers Nicolas Saenz Julienne
2020-06-22 10:38 ` [PATCH v4 6/9] Revert "USB: pci-quirks: Add Raspberry Pi 4 quirk" Nicolas Saenz Julienne
2020-06-22 14:44 ` Andy Shevchenko
2020-06-22 15:11 ` Nicolas Saenz Julienne [this message]
2020-06-22 15:51 ` Andy Shevchenko
2020-06-22 10:38 ` [PATCH v4 7/9] usb: host: pci-quirks: Bypass xHCI quirks for Raspberry Pi 4 Nicolas Saenz Julienne
2020-06-22 10:38 ` [PATCH v4 8/9] Revert "firmware: raspberrypi: Introduce vl805 init routine" Nicolas Saenz Julienne
2020-06-22 10:38 ` [PATCH v4 9/9] Revert "PCI: brcmstb: Wait for Raspberry Pi's firmware when present" Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c0546cfe855eee1381c629b2ffd7f65427c7091.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mathias.nyman@linux.intel.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=tim.gover@raspberrypi.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®