From: Timur Tabi <ttabi@nvidia.com>
To: "kherbst@redhat.com" <kherbst@redhat.com>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"airlied@redhat.com" <airlied@redhat.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>
Subject: Re: [Nouveau] [PATCH] nouveau/gsp/r535: remove a stray unlock in r535_gsp_rpc_send()
Date: Mon, 27 Nov 2023 20:05:18 +0000 [thread overview]
Message-ID: <0c08f93b02df48745342a04a7d3f603f84064a67.camel@nvidia.com> (raw)
In-Reply-To: <a0293812-c05d-45f0-a535-3f24fe582c02@moroto.mountain>
On Mon, 2023-11-27 at 15:56 +0300, Dan Carpenter wrote:
> This unlock doesn't belong here and it leads to a double unlock in
> the caller, r535_gsp_rpc_push().
>
> Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-
> RM")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Nice catch!
Reviewed-by: Timur Tabi <ttabi@nvidia.com>
next prev parent reply other threads:[~2023-11-27 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 12:56 Dan Carpenter
2023-11-27 20:05 ` Timur Tabi [this message]
2023-11-29 2:09 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c08f93b02df48745342a04a7d3f603f84064a67.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=airlied@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®