From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01444314B71 for ; Wed, 19 Nov 2025 07:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763536406; cv=none; b=MJZhT8IwuucCYJ9+btRHPV/HWw1v1BlaSg26fx5fUoLd9lwRPsgLZHf6CuMnsPGQ4SFKuvna3i+0ggZ24f8cExL3w1DlYr8yXgoeKxkKbeCYf5zIPeV1ynbiDC82KC6/jIDl2Jr99E9ix2SCUyKB4jslDw2RCaerN4l+iGxbi08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763536406; c=relaxed/simple; bh=VhO9Zv+AshAVCPbGJujeRwRjVu+5kKh1p4fbomxPCkw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=YVT5cunUHkE+bKh2IzWM3b2al2CqUQDS402xcF0P4jZfQDwHY/5v+1kBh4KflacF9Rvnwm0s2IjBoLAPnfuLKEXU7Z6r/vSiupi5bL3SgqPmIVsytzIdfkWgHbTOyEiJuGQD5ZXj1wVVJs+ewcQoyT3VN7h2m+/r0u5p5CcA5Uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i4mjqmFJ; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i4mjqmFJ" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-29808a9a96aso68375775ad.1 for ; Tue, 18 Nov 2025 23:13:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763536404; x=1764141204; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OQGO1sUYeOJV39MAKgwIerIEJtSj6DSenu+RgUcxLNU=; b=i4mjqmFJB5uLI1cWpMFRkBn7TSYrspQB/wNj9HTSjaCAhBqHMjWGWrr0HdBAF4GJJ+ EgmkNNxdL7xjkhoXyr4FLebulK6HR3Wn/no7srCPqs8HnmygvWHaIpAVVGpwmrBnueGh m4nCdwVWEpoeOziNj4yOWIVhwMHBw9EV4oi5qnMfplcYwI6qHMzRz9pXkEWWuXr9xZ9e pFq1YUp8Fojr5mvtD3uOH1i56CksFNkQQip+laBo9wtuUfZ6qZWHZuq5RiY5RCS3pUmy QvR9v2Nh9OHskAXOWbOqINP/ryy2WnEimDmeWvx6tqCOUMngRJ5p0/fEyJSMYzsl0f5w aBrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763536404; x=1764141204; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OQGO1sUYeOJV39MAKgwIerIEJtSj6DSenu+RgUcxLNU=; b=po5zdymsoGXkS7+fBH2QjIM7nIcQ1TlSpkgc/zhBaj9tom722YMh76nIWx/W+Bci1V 28MJD9G+43NVnN/k1eKWt5Hy5ln8Z91wXisd8oiqQoiJeks8Sqtpi/0t+pk5AkEte5MR J1uijQkzXw9PmOx6MOIvN+nKTyBExYwBzoCriiYZ2FZSZqp1nDiFiaVVJld8nI5uepa7 /mfIKJKlA7HywEfiuxiMwsthnYa1o4TYGXMykjlHmKrHl+uAphPkaUC5U4GSurS4nsAh V2ilolO7CL518UG1yxNpGd0ZNA1j740jp2TPcRFS5+QQO55q0fPoXEwBU7QFWR8NQcir xNOA== X-Forwarded-Encrypted: i=1; AJvYcCVjz9x32hndtcjlFUJeS0A1EIsszwnw5dVYRFqW9h2D92mUTZSGEk40eFTc/01HEcCgjc9s9tWjQl7HvoI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxw3hLzhPkP8UdCy+XbbqMlo7bgmsRADv7s5gFaygssB1hA2L95 HoryQYCxDsPwAeyqRFrG5j1Y8nRTlMuz2lvT1Qkyt+PggjE57proKS4l X-Gm-Gg: ASbGncvhSVNntFA4hT8MrKvv3zUA4YPqIB9D8XkXpD+RrzrrJAAMdZBPABkzSyzSVUd dizipau2SmSUo5rmdLIDfOBgbEEp8kiw+y9i7rpae+eJt7rLg8kCYyOU3VaMXkEgVQ7DXYtssNH QS13yBa3UletnQ4GAnp/lSDXTc+M2VUZ9QyY6sS3U7MVKRWRl19NJcTJpBDFmeO4WnygclP4l37 QDA5g39f5La0kIKKz9hS8/gITE+D5rN0c7Aue7i3q1YmUE9vm7rRxywRs05NivKJDxhxLbzNsfP JKfdkT3l75j8jx0uYRvfkMHbR8rL8ekVIHe0XJhyvblfZP0uyWQ0WxgOm4ItRwzYYG3nVZ+ms2w PGvNBUW3qZcytC5ayFMWHs+j0lLr5ISeyXMY77KqQ/RKILzwHVF257Zv9GvsT3I6uEoEom1Toar Z9SKhv2ap4a6ZfE7iQMoRNuaBMhNCYStLQkq/uH2sT6z9qlRwQoYZe X-Google-Smtp-Source: AGHT+IH/gL6yGt5V0h4Hj7irwb65r1xjme7MQ1YYoWKyR5w4/vb9/Mu1xnBn1mXIZIm+8ACUp3Px0w== X-Received: by 2002:a17:902:f691:b0:295:6a9:cb62 with SMTP id d9443c01a7336-2986a73b4a7mr234874565ad.35.1763536404116; Tue, 18 Nov 2025 23:13:24 -0800 (PST) Received: from ?IPv6:2401:4900:60d7:2218:52ea:a17:db14:a44? ([2401:4900:60d7:2218:52ea:a17:db14:a44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2bf158sm197406885ad.91.2025.11.18.23.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 23:13:23 -0800 (PST) Message-ID: <0c11915eda500f12ed56dd77875c96f53c496fbf.camel@gmail.com> Subject: Re: [PATCH v2] overlayfs: fix uninitialized pointers with free attribute From: ally heev To: Amir Goldstein , Christian Brauner Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter Date: Wed, 19 Nov 2025 12:43:18 +0530 In-Reply-To: References: <20251115-aheev-uninitialized-free-attr-overlayfs-v2-1-815a48767340@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2025-11-15 at 14:59 +0100, Amir Goldstein wrote: [...] > Christian, >=20 > Mind picking this one? >=20 > Thanks, > Amir. >=20 We might want to wait. There's an ongoing discussion going on about this rule https://lore.kernel.org/lkml/58fd478f408a34b578ee8d949c5c4b4da4d4f41d.camel= @HansenPartnership.com/. Mostly likely, I might have to revert to v1 of this patch =20 > > fs/overlayfs/params.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c > > index 63b7346c5ee1c127a9c33b12c3704aa035ff88cf..37086f73ac3ecfcd1c09ae6= eccbb69723006e031 100644 > > --- a/fs/overlayfs/params.c > > +++ b/fs/overlayfs/params.c > > @@ -448,7 +448,7 @@ static int ovl_parse_layer(struct fs_context *fc, s= truct fs_parameter *param, > > err =3D ovl_do_parse_layer(fc, param->string, &layer_pa= th, layer); > > break; > > case fs_value_is_file: { > > - char *buf __free(kfree); > > + char *buf __free(kfree) =3D NULL; > > char *layer_name; > >=20 > > buf =3D kmalloc(PATH_MAX, GFP_KERNEL_ACCOUNT); > >=20 > > --- > > base-commit: c9cfc122f03711a5124b4aafab3211cf4d35a2ac > > change-id: 20251105-aheev-uninitialized-free-attr-overlayfs-6873964429e= 0 > >=20 > > Best regards, > > -- > > Ally Heev > >=20 Thanks, Ally