From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0B031E1C2B; Tue, 7 Jan 2025 13:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736257198; cv=none; b=X8hVzKMdZnJ6HN/epHKjMlfb4m1cQ9m2E2fZDLLZ6vCAzp9JqvAO3HwFD1hI1xfopjuZc6oDoriLTM7BX1wqOWEFedPAL+GvDNv/B1LZ1jv5H91wbjtD4JvB9mpJdVxUiv0uTeSTvkoim1Re80f7BYdzGiYrq3pw607pTcMGelY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736257198; c=relaxed/simple; bh=fc+rpQovhI9z6HNuLLy8SAZQh6kHqf94pndeUeLrhZ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dxxG3+1AiTxYirDJOWO2Hm6G/bpjAPokTF2GRPktJ/v2FDd0wNWzKF6jYT73/S6Zo60JFMHdRCklAeX3CrzfMYxKTXn0B2ozZXqKR7PW/9IArFnzk3Gk0SH1iA86vNeyX3Ty3Q9kER0KZHFVoXAVSKjl6PhzMui9wE6gvc8AbmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=M1ZAgJtn; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="M1ZAgJtn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=DPozk7f2ck1lekTyYQRxycAO00Td6kCk3wOh3bU6cO4=; b=M1ZAgJtndU1q5MC64JZ16ox9ak AZQZHJrhWTtBHgy930N2oaZiUwaukNGEmE+JgaqnSySdpI3hvC+mob32gUCqYws2w940neX/sy+zZ 18mnFrmshJ0YZUJFUI7hG2yAGJJ1YmA/YRGrWv8n0HvSKgnkBSqZI4tObIfUXSHzZETc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tV9o9-002F7p-8S; Tue, 07 Jan 2025 14:39:45 +0100 Date: Tue, 7 Jan 2025 14:39:45 +0100 From: Andrew Lunn To: Furong Xu <0x1207@gmail.com> Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Torgue , Jose Abreu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , xfr@outlook.com Subject: Re: [PATCH net-next v2] net: stmmac: Unexport stmmac_rx_offset() from stmmac.h Message-ID: <0c190dac-dc97-404c-94e6-7a950dcfc8b7@lunn.ch> References: <20250107075448.4039925-1-0x1207@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107075448.4039925-1-0x1207@gmail.com> On Tue, Jan 07, 2025 at 03:54:48PM +0800, Furong Xu wrote: > stmmac_rx_offset() is referenced in stmmac_main.c only, > let's move it to stmmac_main.c. > > Drop the inline keyword by the way, it is better to let the compiler > to decide. > > Compile tested only. > No functional change intended. > > Signed-off-by: Furong Xu <0x1207@gmail.com> Reviewed-by: Andrew Lunn Andrew