From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752927AbcHQRhy (ORCPT ); Wed, 17 Aug 2016 13:37:54 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55088 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbcHQRhw (ORCPT ); Wed, 17 Aug 2016 13:37:52 -0400 Subject: Re: [PACTH v3] mmc: sdhci: Do not allow tuning procedure to be interrupted To: Adrian Hunter , ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Bresticker , Kevin Cernekee , Benson Leung , Christopher Freeman References: <1471382729-28472-1-git-send-email-robert.foss@collabora.com> From: Robert Foss Message-ID: <0c1a3043-9ed1-9d01-0f07-231d6ece874f@collabora.com> Date: Wed, 17 Aug 2016 13:31:16 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-08-17 06:47 AM, Adrian Hunter wrote: > On 17/08/16 00:25, robert.foss@collabora.com wrote: >> From: Christopher Freeman >> >> wait_event_interruptible_timeout() will return early if the blocked >> process receives a signal, causing the driver to abort the tuning >> procedure and possibly leaving the controller in a bad state. Since the >> tuning command is expected to complete quickly (<50ms) and we've set a >> timeout, use wait_event_timeout() instead. >> >> Signed-off-by: Christopher Freeman >> Tested-by: Robert Foss >> Signed-off-by: Robert Foss >> Reviewed-by: Benson Leung > > The mmc block queues are kernel threads which I would expect ignore signals, > so I am curious how you hit this? The issue was discovered on (tegra2?) hardware that is sensitive to being interrupted during tuning and having the controller left in a sensitive state. @Christopher Freeman: Maybe you can provide us with some additional details? > > In any case: > > Acked-by: Adrian Hunter >