From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80AC3223336 for ; Thu, 2 Apr 2026 18:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775156211; cv=none; b=rMaBOsOMXf56E7enValYSy+4BOt9UdiyWEc0dyUKcYse3IzunoY+7fuUHqKF3yReXY6EptcePyhFZDWzyuL24RXJKK9KqBp7qoKN6XU/kUZe6CPxgMGNhZkNqKZPU3X+3JRLVIIJ7d3pUJvT/T62X0RN/SmrBevYC2c69cEcQwM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775156211; c=relaxed/simple; bh=GR/HDV3hC/Ih5gBR61ldxTjEJqaFC4QFcCNuYrGfEsQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PXEFajbSuFCn9W6NB7nDTDQvGoaifjhY7A7evbsN8XfILPyLFknXm93v+hyszR1fjxxHoQSjiKexA1xQ/f9HIDi6lff+yLViVHGGl3RhWrveMFiBPZ69kWfB6/KuSi34SraaKptwU7hUdoaWs2K9Hih0OIPedNxCxoMFGfIY4EY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TAr3PanS; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TAr3PanS" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4888244e9f9so11108925e9.0 for ; Thu, 02 Apr 2026 11:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775156208; x=1775761008; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0m9bXJvgrALKJ9p3Q2n22qDrsxN14oouyQEW4vfGf5E=; b=TAr3PanSUJrTEjcVRr0niPVcvaLIyvG2QS/w+aO9E3vyP4q7f1gHTf89qlrZEhdSju 6DGJB0clgWs01mCoh75RK0KEeY8HhrdrAM4IOAJ1rOZ7Y8PT9/MxMtdreyGqlK1wS3SK DEH+tvKHGHz4Xwvs0fc4jyDhYbQoqoVcIdMdSyZR6d3kfsrrEiU0lUHQQLiOz2LtKLhm +CZiOoyWcv1PYcPFZ4ZX9z0ISBZ3MafCAW04EQL7dDv+0jB7YG65MM+HczEcBmH7ZrL9 7r03bAPL57y3M570u6IJpuzrnpzBI5uPOo6FABWnWkxNFi704pNdM9SO9ILuPCY+nyJk tdGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775156208; x=1775761008; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0m9bXJvgrALKJ9p3Q2n22qDrsxN14oouyQEW4vfGf5E=; b=hWAy3y4KiEDmAmCnc8uUNLk3N8Ef4upFAvPgSYZntY2E5Hahmi2LK8nZX+a5z0yBI9 nhPcbPo7QKFG4IqAf8doWchIK5AgFbUoJtsr/U3OeaWfoe/KLUOMehgxz8Brsglo0/aB V1U5602DAfnCBVcQosrOKs2AnojIRW65HMxuwDtc8B3wZ92NrL4YmceOXepxrLRPMRNH JlfEFoe0zEpXJB2qAF8yZHIP/k3rTDctNPI7NiByCoix44ZEYYN7SHtaLhwVfdtXR5xu 2ktBhJxyBcW3ng3+Te53PTVQULLF6tDf2FyF2x4xFbefdLPvoVkJaB/XZLp+5Ldfm2bt qmjQ== X-Forwarded-Encrypted: i=1; AJvYcCWaRcZQtzVQrCWoKmqrp+HOt8U/oLZS8ARIUtdo7IM4wGW1oKpyjDXB0mo3uk1APHcR66Jl7qW1ouWSlr4=@vger.kernel.org X-Gm-Message-State: AOJu0YwNd4QVdW4PuTMFBMIqdWtanPZvklIh0G6s5uZMm30udAs9HD5E vzwVnSEgfeXRiL0DophiWVCKdCFT98TTufOb420DB7nanthR5D+dIYPuwiloIO+swDE= X-Gm-Gg: ATEYQzwOary0jdaTSsimukdAM2ate1d7rpxxsKVQjFxG9EZIcmTcRghC7WyZXapGbfU xVdjgjCW1GTsbJIZmMu75bn6oi6kOWWtfvDal1Bg4HLVbRYP5D7/ngno1Fh6V1ZwHjMYoyZH5WJ AlGa8D3iYOIUb7oF3dFEPLJqDAbATMZLse+/7qU3JM3KGqEnkLH0vk/5d08kOnq2c+D6FMMT9YU 9jMEPUrjU3+HF2ts2cMA0gfuRCL3Pj9pEzgMFl0rKU84z2I+11ytQ7dtlasANw1GQUaY30LLjyO dPe7B0jLRi5R9/wDpW0RnxpMf4p5Z5q0GQUpUVL3zetKsMBGs4WnsyZNlHgN8rEF5uHXFyOzYao 3v4ZBk01AwhOPNWOWcrzTgJ12w65MSyzWlmfrtHMo3Z4yftErXyJPaX6Lrb4hMv8Sv5BIBMr/+f i/hxv0rQHbOLXj39g9DSPcgmg7MKatUOQFOb+SLQz2TY29T843RjrVqbQ2wSse6Pv060M= X-Received: by 2002:a05:600c:6095:b0:488:8bdd:cfcc with SMTP id 5b1f17b1804b1-488995cbf65mr3822905e9.0.1775156207780; Thu, 02 Apr 2026 11:56:47 -0700 (PDT) Received: from ?IPV6:2001:a61:1398:d301:5a18:8325:8d63:9a52? ([2001:a61:1398:d301:5a18:8325:8d63:9a52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48897b8176fsm4653395e9.0.2026.04.02.11.56.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 11:56:47 -0700 (PDT) Message-ID: <0c1ab966-97b0-49b3-989e-c6bd2a8d1c79@suse.com> Date: Thu, 2 Apr 2026 20:56:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] USB: cdc-acm: Add quirks for Yoga Book 9 14IAH10 INGENIC touchscreen To: Dave Carey , oneukum@suse.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260402182950.389016-1-carvsdriver@gmail.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260402182950.389016-1-carvsdriver@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.04.26 20:29, Dave Carey wrote: > The Lenovo Yoga Book 9 14IAH10 (83KJ) has a composite USB device > (17EF:6161) that controls both touchscreens via a CDC ACM interface. > Interface 0 is a standard CDC ACM control interface, but interface 1 > (the data interface) incorrectly declares vendor-specific class (0xFF) > instead of USB_CLASS_CDC_DATA. cdc-acm rejects the device at probe with > -EINVAL, leaving interface 0 unbound and EP 0x82 never polled. > > With no consumer polling EP 0x82, the firmware's watchdog fires every > ~20 seconds and resets the USB bus, producing a continuous disconnect/ > reconnect loop that prevents the touchscreens from ever initialising. > > Add two new quirk flags: > > VENDOR_CLASS_DATA_IFACE: Bypasses the bInterfaceClass check in > acm_probe() that would otherwise reject the vendor-class data > interface with -EINVAL. > > ALWAYS_POLL_CTRL: Submits the notification URB at probe() rather than > waiting for a TTY open. This keeps EP 0x82 polled at all times, > permanently suppressing the firmware watchdog. The URB is resubmitted > after port_shutdown() and on system resume. SET_CONTROL_LINE_STATE > (DTR|RTS) is sent at probe and after port_shutdown() to complete > firmware handshake. > > Note: the firmware performs exactly 4 USB connect/disconnect cycles > (~19 s each) on every cold boot before stabilising. This is a fixed > firmware property; touch is available ~75-80 s after power-on. > > Signed-off-by: Dave Carey > Tested-by: Dave Carey Acked-by: Oliver Neukum