From: Robin Murphy <robin.murphy@arm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-serial@vger.kernel.org
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: implement a rx led trigger
Date: Thu, 3 May 2018 13:33:10 +0100 [thread overview]
Message-ID: <0c1bb915-bd92-4433-61ec-78fdba453396@arm.com> (raw)
In-Reply-To: <20180503100448.1350-1-u.kleine-koenig@pengutronix.de>
On 03/05/18 11:04, Uwe Kleine-König wrote:
[...]
> @@ -157,6 +158,18 @@ struct device *tty_port_register_device_attr_serdev(struct tty_port *port,
>
> tty_port_link_device(port, driver, index);
>
> + port->led_trigger_rx_name = kasprintf(GFP_KERNEL, "%s%d-rx",
> + driver->name, index);
> + if (!port->led_trigger_rx_name) {
> + pr_err("Failed to allocate trigger name for %s%d\n",
> + driver->name, index);
> + goto skip_trigger;
Hmm, isn't that a rather awkward way to spell "else"? ;)
Robin.
> + }
> +
> + led_trigger_register_simple(port->led_trigger_rx_name,
> + &port->led_trigger_rx);
> +
> +skip_trigger:
> dev = serdev_tty_port_register(port, device, driver, index);
> if (PTR_ERR(dev) != -ENODEV) {
> /* Skip creating cdev if we registered a serdev device */
next prev parent reply other threads:[~2018-05-03 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 10:04 Uwe Kleine-König
2018-05-03 10:10 ` Pavel Machek
2018-05-03 11:52 ` Uwe Kleine-König
2018-05-03 12:33 ` Robin Murphy [this message]
2018-05-03 20:19 ` [PATCH v2] tty: implement led triggers Uwe Kleine-König
2018-05-04 0:29 ` kbuild test robot
2018-05-07 8:02 ` Johan Hovold
2018-05-07 8:41 ` Uwe Kleine-König
2018-05-07 9:27 ` Johan Hovold
2018-05-10 11:14 ` Pavel Machek
2018-05-10 11:25 ` Robin Murphy
2018-05-12 19:00 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c1bb915-bd92-4433-61ec-78fdba453396@arm.com \
--to=robin.murphy@arm.com \
--cc=f.fainelli@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®