From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/4] clk: qcom: videocc-sm8150: Update the videocc resets
Date: Thu, 16 Nov 2023 14:59:42 +0530 [thread overview]
Message-ID: <0c1d1ccd-fff8-fb4f-12c0-8b60f3e5c3e2@quicinc.com> (raw)
In-Reply-To: <bee6062d-55ad-4577-8478-d20881c5047d@linaro.org>
On 11/15/2023 10:39 PM, Bryan O'Donoghue wrote:
> On 15/11/2023 16:48, Konrad Dybcio wrote:
>>> + [VIDEO_CC_INTERFACE_BCR] = { 0x9ac },
>>> + [VIDEO_CC_MVS0_BCR] = { 0x870 },
>>> + [VIDEO_CC_MVS1_BCR] = { 0x8b0 },
>>> + [VIDEO_CC_MVSC_BCR] = { 0x810 },
>> FWIW this seems to be a copypaste from
>>
>> https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blame/92b31370d31d22e910120f6a875bf0919b3f1773/drivers/clk/qcom/videocc-sm8150.c
>>
>>
>> so if it's an issue, it should probably be fixed downstream too
>
> More of a question than a gotcha - 0x9ac is valid for sm8250 so
> curious to me that its a different address on sm8150.
I have re-checked the offset values, as per the HW plan for SM8150 below
values are correct:
+ [VIDEO_CC_INTERFACE_BCR] = { 0x8f0 },
+ [VIDEO_CC_MVS0_BCR] = { 0x870 },
+ [VIDEO_CC_MVS1_BCR] = { 0x8b0 },
+ [VIDEO_CC_MVSC_BCR] = { 0x810 },
> ---
> bod
next prev parent reply other threads:[~2023-11-16 9:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 6:50 [PATCH 0/4] Add runtime PM support for videocc on SM8150 Satya Priya Kakitapalli
2023-11-10 6:50 ` [PATCH 1/4] dt-bindings: clock: Update the videocc resets for sm8150 Satya Priya Kakitapalli
2023-11-10 7:51 ` Krzysztof Kozlowski
2023-11-10 6:50 ` [PATCH 2/4] clk: qcom: videocc-sm8150: Update the videocc resets Satya Priya Kakitapalli
2023-11-10 11:49 ` Bryan O'Donoghue
2023-11-15 16:48 ` Konrad Dybcio
2023-11-15 17:09 ` Bryan O'Donoghue
2023-11-16 9:29 ` Satya Priya Kakitapalli (Temp) [this message]
2023-11-16 9:55 ` Bryan O'Donoghue
2023-11-10 6:50 ` [PATCH 3/4] clk: qcom: videocc-sm8150: Update the video_pll0_config Satya Priya Kakitapalli
2023-11-10 11:16 ` Bryan O'Donoghue
2023-11-16 9:31 ` Satya Priya Kakitapalli (Temp)
2023-11-13 12:07 ` Konrad Dybcio
2023-11-17 11:05 ` Satya Priya Kakitapalli (Temp)
2023-11-10 6:50 ` [PATCH 4/4] clk: qcom: videocc-sm8150: Add runtime PM support Satya Priya Kakitapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c1d1ccd-fff8-fb4f-12c0-8b60f3e5c3e2@quicinc.com \
--to=quic_skakitap@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®