From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932594AbdBHANI (ORCPT ); Tue, 7 Feb 2017 19:13:08 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:36007 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbdBHANF (ORCPT ); Tue, 7 Feb 2017 19:13:05 -0500 Subject: Re: [PATCH] gdrom: Add missing error code To: Christophe JAILLET , References: <20170206220013.3851-1-christophe.jaillet@wanadoo.fr> CC: , From: Jens Axboe Message-ID: <0c1d5da3-ce57-8687-f0f2-8ae12b40ccd8@fb.com> Date: Tue, 7 Feb 2017 16:17:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170206220013.3851-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BN3PR0401CA0041.namprd04.prod.outlook.com (10.162.159.179) To CY4PR15MB1191.namprd15.prod.outlook.com (10.172.177.13) X-MS-Office365-Filtering-Correlation-Id: aa0641f2-9ef0-442a-dcfb-08d44faf89be X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR15MB1191; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;3:vmOXCyTSD0XYtPdYzCyLVUK2pQpFEriGgRIDAmp2ow/FL84QrjOzB7gE525V/6ob1gGMPZhbatRnZ0s23SaRfCZ6jd2/+p0kk5IYIEkPhAOfEoChZmGgXXtcoaAnzdn3oe58vmLvluQdUD8lEjykDUYs+YWXZlPXcX3bm5ucSPAu3KQuGYad4wapu41GBwSBOpOjaDusnrugL0uNiXh4s65yF4FDOT6wauDc+cnSQyXoNNITx9q7o+8KwEirTMRNFbo/ggd3FQtx0HmYS+ByVA==;25:F2MWjQslKXMCjxyyivjjYQ+wdJILTS/bXlDXVbrkXsWENcKz7d724OLrBk+niwGCvXtYI+sNg9hyKu74aXUtPsJWFKSWqYtalNX4rdyPzIiY6Yt27RRvwzvguum8Ej3qsBDkQxARJplR3MGVT/+x7uUuqClQnpLKvkLCZxs9hGBsBOzbgnrRJXXOOAQaj9X1inX0dgX0aaVMMxA34yK9ah/DPo0sGHjPujd/aIU3NPpxEqNt7c8g7J0Q46X2Un8CZFIMlwf1+RGGb70vMPDSlWahAjN3QKxPVH2oaCRbzYrQUXCYhF0gk2KDBRU3yCmoao+hIDCuYkQEhtTS55IS+GhC2tlSAjESk7LOXqlRK1uXVbUZ0DRF/uJsIN5bZGUtKcb2cbZU+mWJp2/3tuWRD/AH2LqE0kJOcnIuxXgNBlulCGaUi2vNKFZ+c+mQBBW4lMKqW2xM3rl5UuAQJ7oPjQ== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;31:o7uhQKnMcqa1cA6mlmfhCRQr/62ezKUqXMipZWj0Mnc6BHgGKlaU2hZKFqIJS0x0liYuTTigqOUGwTYF7GNubvVui6yRcza4z6aDVj4RhCmmwBfyG1ufq9iZjN5YcbWVxT6xkN40rKGQOkIbt0J1MnzWlpdQXt81HjrXgoZaQwvV4fwiseoTV8rNkB6vcldu/Z86y5GWemR8t+3eAz/EOIrhOAxB2a3BPZYA+K8GfXUBkq8WLowzl5WSyjwHJftM0GBCEBVNJUyXhKiAYwUBYg==;20:GZdgfX6WyCFN671r7l22nQaM5jUGV6snUo8K9N55OpQzOwqkz2RS1Ybi9zDdEhKRimLT/Ah6KSbIKjK/fCIs6dyxdmLvpHyj2vsOBQU2APJ6zvkcS2vNHW856ide4vHiJQ554F62bim0g9qdXlapRiv/40jsa7QylyHbTRx4zDfyrZhW6ouqgFVkMWuuZujGNy0f8CtYDHKWbVwmXenrGT6itTVTtoombzA8B1k55/meNr+Svj19+hRijobl5bXSIA10eui52wZO5SloGP/8CDALWMtOMbtYTq37NhO0Ypn9UCas/ik9sQMFKboNZFQnd0S6pPT5ly88kZ8zvQq9cSbuITLlMpP2EOJO2+fhyXGpYxlP50HAQ3SRfk5Z5I3Xx7Vx5pjAxykXiTK6wa5wKzpCjd8yG36S14n+2mGPNjiV0qyUGUn9tE8glTktwDnpZ8zRrhAlYGxm2qpBjjMjn0qfsxCYLaMWbwOuSxvRdYmCaqo9Q556Kj9OPjz5I04p X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(2017020603029)(8121501046)(5005006)(20170203043)(3002001)(10201501046)(6041248)(20161123555025)(20161123558025)(20161123564025)(20161123562025)(20161123560025)(6072148);SRVR:CY4PR15MB1191;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1191; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;4:y5OIiGa5S7FW3hILN89XdfvbvECuo4r2//hMiHI7vCRHC/mlXdbhhYPhB8gV6POFDvSAzUpubai2WQlAPmdpQIxuiXw6a3TVS44W8dNEN74CJG3llDkZoKeuNW1kytPI/beD2pIy3Z0Mxbh3fT4twdOijrVsHSNEM8XOAwSmUhFVnWVrIWBcTR1YVKjMabxe5MC4WPDcUxGxwXfUbcuMV8oKAm1pUxAYjEkiLrpdFHTDSUtO+H5at4mgB/FTZXgWuANajrTHzoso88L/reociSffTmMEm5GomSp2BPIGFzZEUHsEvyjUss0v5iflO/9xkEPImAqhOJp+DF12cheOoBGrEaySiDTeo2JSRA8hGx/QB5qNKStM2XuayytmAieeWjawflMeyw6/BW8TFAQcANwOFJYva4XltJj4MHD8jRhuKgnlxv2Zt0ZTuxnf3s6Qjkzi3VAJNJ44x++sTQXOlHrS0CF8FkGM9ilim8quPeUEESUeutgyVR2PtfzHPEep++LH9p62nuBfC2/Egr8vwANA5mHWmtrEIVaPtNy/v/0IdqGEUVU20uRGg7+XfdsEmEPnoP4tzPk9nfdQOhYZJg7sxRxmOn22nB0Yls/HR3Wmm1QE+kDRSoyeXy7bWS9N/xX8HU04iyXv/xgRAQXlq8R4eJChyF7qL8lDllwHp2k= X-Forefront-PRVS: 0211965D06 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39450400003)(199003)(377454003)(24454002)(189002)(36756003)(101416001)(64126003)(90366009)(23746002)(54356999)(54906002)(50986999)(76176999)(4001350100001)(6666003)(2950100002)(38730400002)(6116002)(65826007)(81156014)(2906002)(81166006)(50466002)(8676002)(5660300001)(4326007)(31696002)(3846002)(83506001)(86362001)(65956001)(65806001)(66066001)(189998001)(31686004)(42186005)(53546003)(53936002)(6246003)(92566002)(47776003)(106356001)(6486002)(105586002)(97736004)(558084003)(77096006)(7736002)(305945005)(229853002)(33646002)(68736007)(25786008)(230700001)(117156001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1191;H:[192.168.1.154];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1191;23:uFcnKfwRoSYCJDzgEsuZ2eQfqtWl7nlbf2rMj?= =?Windows-1252?Q?uxpjHEf386vPuPanfPWubRgEFMGes9zHdnKD4Uhl6EhkAimNAA+3Ub/8?= =?Windows-1252?Q?u6UIOAT4YxwqKdArQHtC+IxMfSFPFxqWKEefF34uiQPY6irCPHwYT24A?= =?Windows-1252?Q?lsqZtmmF+PI7lv3JizPaFsL3NYsZ1aOhU4z5sIXbfK5ESRS3LmtzV06g?= =?Windows-1252?Q?hTUmWeKO7L3/Ec6RBkD/bJXyYHucZLcF/m/AhOo8PvaOPavDyL8TobX5?= =?Windows-1252?Q?xOeCaOJLXVHYwO6uEtKxvkovkOXKwCX18gpH9bEhbBDzJiaj41uS1+Fw?= =?Windows-1252?Q?Yb1In96h3GLc7hvA/2/WWgWl+YI6Ud0kEH1AV486AxRTcmDzF8IFbqG8?= =?Windows-1252?Q?EQaRa1Rn3TjGHR9jaYcUmJqy9J/WEWtVduPyNDPIAmPqO3sQBVG7Opc3?= =?Windows-1252?Q?OaV3X+KperAdcir1GDSgtydrpy0qj6XK1l2Kll6wD/35hhjXxvOhzp06?= =?Windows-1252?Q?Ch3pZC1cwKEgfO1pF3xg14/ofC2Xto1wbvLAja5LuDzXPBCmuWgnQLWP?= =?Windows-1252?Q?4MBkzK9eH//MYYm+66cpL0wC65ZCofTcCx0YI6X/ZVf75LJ9DbjvAc0I?= =?Windows-1252?Q?PwKI7iyI3GuHclvXuH9qkCu0U/sX5BYZXBmgG9byJr2IInA9pRdUsl6u?= =?Windows-1252?Q?cl4bZwIueKh6kEoTEaeAj2yTdWDMl8O6zbPIhduLCESCLpWGPsrUTtxE?= =?Windows-1252?Q?TIdGO+fL6gCoLpvW6S1J5m/SGhB1fFn8YnQFRXK35wP6ZcGEzwSmumMO?= =?Windows-1252?Q?Kax2VIqTZJ6R1iESWa1vEcx2wjs2rbC/1rhmRvB2Q2jRzhsAmMyQA42O?= =?Windows-1252?Q?Xr82ZpBmVouKLzc5OAFo38fQJfSJexdrlqoao1xYeFhM7Jhv/w2AjlLr?= =?Windows-1252?Q?7I52FwlVhu8mAdGQDRfrDlyPbmBimFElXZq5keCg2dhIyk1NblYLBhpI?= =?Windows-1252?Q?lHJquSLpKpA8MXIM4W/Il06QHDnifsauni9nxHmvzsbPYYHP6tid//+A?= =?Windows-1252?Q?HSpalxGSqpvZDmx5rgDYBuLG8tusI/GSJtTbCzf6xNUbwssKAecaG57Z?= =?Windows-1252?Q?EQNL4rcrHGTKOlf8YSYouxS7DNCemCXzghHKRdmIP15v7cU60Gyjzikn?= =?Windows-1252?Q?5u41ZFGLQYCYOIjTXbmLweHoqs7z3wW3FSoY5WQtMLuKEfJ9cil4EwTs?= =?Windows-1252?Q?zwWqH0RdWLVnGyDPUoyEPor59y4LQrquUDcrcQsKaY3pHsj7mBKw3ev2?= =?Windows-1252?Q?T6o9Gz/Trw+ted2zTvS01Z+zJ5QEdDTsKoKSH02dcUSuv4nu2j+Au6bh?= =?Windows-1252?Q?ZdcMqyK60ztJp91lyHAvQPKBcIKZupSu06gMxZ1+8TqJnztV5JH5+yQ3?= =?Windows-1252?Q?W7R5KeTM+wOkqmDVFwTSfYP033WZR5B0CPSljAZVLXqdFL7zqZxU99B2?= =?Windows-1252?Q?F+Y75SAEDtBUtHj7eq3Xp13fdYBurpdXUlMSOM634UkvVemKA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;6:To9CY6+oVqouZHdNyJDLBRVI2phZaoch4Wi0vjHD1DZRJCiJpLwLyv5Eheex22wLdrbuaCyUAVz9GBxEEFHSp8eBUhNnMIbryIaXW+zeXlSr/8fF5xlbtNUMJlihK+rsRWRMgavx2qil06SMvJlIBPhGC6hT5l5Fkol1zPHkwLP3Q95MihacDt5A0JwJvUaXVyE8WG4yAMW8HB5K6x/tLZ/P+qGGj/n0qPIEZ6x5sMELefntrTEaLUWA0ycr1etSXsyU8rnQ7a9seDKCoGl6QZvY532Hs9wHf+V5NXl0P9KM2i+gTsR0bx4sBZQUyc9S8An6WXxrqiObh6sv5SmjPiYYjDkNJmIA29FssAmo5RHIFrcgHoA5sCjVjTb9btCan3GMSqyvCbYQtep1sRlTHw==;5:POq1kViNz/96TcxgDd8nRqwcg7b7lfyPGt5DAzrnRAzhDfPS9Xo9sMfoK0C6EZByiPKQ7ibiy6DwXoQzwtkm8Z4/+OEyar04FQY44go9BQd2L3XpyP0YLcl8Vi72q17hw54S8QPZmEwSd9INu0PKyWGfU3MMp9923JSu9Dyc0Ec=;24:uR7jZ3u7r4L4pO/USCa4ngwNJ9XqJBJun0zyX+Ohdkl1u0ltRb3XHUjETMnrD+rhsU0Ldq9oytxIBXHBW2Dc8uct6E0ylux5OHmN6mVmwgo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;7:YxDnGX+9A+b0h3tiTKpzJvTP37tE+b1F2Js6Ot/vTvNuZISx2Ji3ZGDSBStwa3ESt+9K8mD4P9XmOTjpxe6SYqgn+8ir03TYhIeAXQ0MZIstJnrKMd80fJPLMWBgpgej1IduD+94ndKItyPBjlWDOVB90qwVpYGDMDZ5hxwpeHtTxGWi5WAgT6AiKMn1DFb4hAo7R4F4A3zJFF1d/XGVyEVETultZ/NfeOQNGcMCDGwW+vQAoLoEcKdOaj/LFQPeiMql6bn3v7rHpHogq+4+kxJZcgIO4+MiTb8kX5MszrFPada9ma2VBQYXUrBcMyF4IRGRHQn7sC6KtAHCtO2Z8210AsOTcqwcyrMn8NW/0lvQxQN+NTLWj5wpuX5m8GwYxtiBYWepRkqy1kOea5gSesM/eEbja4pakuv5YIg0TsX0F0iOSgmdBUkrqYp+ck+z9Mf2z8GtdTe2fiHBcwJv5Coy9z3ELpYf2PjLYrroGxHju6WI7YpmqNqcKmpedEaRV9rDVkvpHgcCcRjernPtDA==;20:cs2i3geA/1VBTMIsqQzboWOHD4YQSQxxhlu5J6fFk/JO2SAvAuvuqROBuoURAiIcAKJrjWpyaRFhhmxxRb5nrITr81LX8sDKcyYohzGHVJp8aGBNIw1clo7fwGpcoIAtndZ851PdUH1thQ1ENK+22ChQBYCU7yCuPaVE1yMro6k= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2017 23:17:50.1579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1191 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-07_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2017 03:00 PM, Christophe JAILLET wrote: > In case of error, 'err' is known to be 0 here, because of the previous > test. Set it to a -ENOMEM instead. Added for 4.11, thanks. -- Jens Axboe