From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
lizetao <lizetao1@huawei.com>,
Bui Quang Minh <minhquangbui99@gmail.com>
Cc: David Wei <dw@davidwei.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in io_uring_mmap
Date: Fri, 21 Feb 2025 09:39:55 -0700 [thread overview]
Message-ID: <0c1faa58-b658-4a64-9d42-eaf603fdc69d@kernel.dk> (raw)
In-Reply-To: <79189960-b645-4b51-a3d7-609708dc3ee2@gmail.com>
On 2/21/25 5:20 AM, Pavel Begunkov wrote:
> On 2/21/25 09:10, lizetao wrote:
>> Hi,
>>
>>> -----Original Message-----
>>> From: Bui Quang Minh <minhquangbui99@gmail.com>
>>> Sent: Friday, February 21, 2025 5:00 PM
>>> To: io-uring@vger.kernel.org
>>> Cc: Jens Axboe <axboe@kernel.dk>; Pavel Begunkov
>>> <asml.silence@gmail.com>; David Wei <dw@davidwei.uk>; linux-
>>> kernel@vger.kernel.org; Bui Quang Minh <minhquangbui99@gmail.com>
>>> Subject: [PATCH] io_uring: add missing IORING_MAP_OFF_ZCRX_REGION in
>>> io_uring_mmap
>>>
>>> Allow user to mmap the kernel allocated zerocopy-rx refill queue.
>>>
>>
>> Maybe fixed-tag should be added here.
>
> No need, it's not strictly a fix, and whlist it's not yet sent to
> linus, the tags only cause confusion when hashes change, e.g. on rebase.
I do like using fixes still, if only to provide a link to the original
commit without needing to dig for it. And yeah there's the occasional
rebase where I forget to update the sha, but those get discovered pretty
quick.
--
Jens Axboe
next prev parent reply other threads:[~2025-02-21 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 8:59 Bui Quang Minh
2025-02-21 9:10 ` lizetao
2025-02-21 12:20 ` Pavel Begunkov
2025-02-21 16:39 ` Jens Axboe [this message]
2025-02-21 17:06 ` Pavel Begunkov
2025-02-21 17:28 ` Jens Axboe
2025-02-21 12:14 ` Pavel Begunkov
2025-02-21 16:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c1faa58-b658-4a64-9d42-eaf603fdc69d@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=dw@davidwei.uk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=minhquangbui99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®