From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753350AbeAIJsM (ORCPT + 1 other); Tue, 9 Jan 2018 04:48:12 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37209 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752613AbeAIJsH (ORCPT ); Tue, 9 Jan 2018 04:48:07 -0500 X-Google-Smtp-Source: ACJfBotJM75+qVONiTxBBH64pr8A0d31Osix0WmH857PWpBqyLFy4joSMuIQ7hhPSwRNehGcJHYJrg== Subject: Re: [PATCH] slimbus: Unlock on error path in slim_msg_response() To: Dan Carpenter , Sagar Dharia Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman References: <20180109093435.4n45kxibmpvpb5i2@mwanda> From: Srinivas Kandagatla Message-ID: <0c22be94-b5dd-171a-4c17-94aaaae4dee6@linaro.org> Date: Tue, 9 Jan 2018 09:48:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180109093435.4n45kxibmpvpb5i2@mwanda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 09/01/18 09:34, Dan Carpenter wrote: > We need to unlock and restore IRQs before returning on this error path. > > Fixes afbdcc7c384b0 ("slimbus: Add messaging APIs to slimbus framework") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c > index 755462a4c75e..94818a8427e2 100644 > --- a/drivers/slimbus/messaging.c > +++ b/drivers/slimbus/messaging.c > @@ -36,6 +36,7 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len) > > msg = txn->msg; > if (msg == NULL || msg->rbuf == NULL) { > + spin_unlock_irqrestore(&ctrl->txn_lock, flags); > dev_err(ctrl->dev, "Got response to invalid TID:%d, len:%d\n", > tid, len); > return; > Pl note that there are already some patches in flight which are yet to be merged fixes most of the static checker errors : This is already fixed at: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1575798.html