From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24FF7CCA47E for ; Thu, 23 Jun 2022 04:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbiFWEs6 (ORCPT ); Thu, 23 Jun 2022 00:48:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238158AbiFWDeX (ORCPT ); Wed, 22 Jun 2022 23:34:23 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 728D036155; Wed, 22 Jun 2022 20:34:17 -0700 (PDT) X-UUID: a79ae7d571454f528d2d996e8fb2a215-20220623 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:c7583246-f3e0-477c-a035-85da7ab95b6b,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-INFO: VERSION:1.1.6,REQID:c7583246-f3e0-477c-a035-85da7ab95b6b,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTIO N:release,TS:45 X-CID-META: VersionHash:b14ad71,CLOUDID:67213c38-5e4b-44d7-80b2-bb618cb09d29,C OID:7494f817c6eb,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: a79ae7d571454f528d2d996e8fb2a215-20220623 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 106634298; Thu, 23 Jun 2022 11:34:11 +0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Thu, 23 Jun 2022 11:34:10 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 23 Jun 2022 11:34:09 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 23 Jun 2022 11:34:09 +0800 Message-ID: <0c269c54042d556bd5c7f4a7a13d4e33074888d1.camel@mediatek.com> Subject: Re: [PATCH v13 12/14] drm/mediatek: dpi: add config to control setting of direct connection to pins From: Rex-BC Chen To: AngeloGioacchino Del Regno , , , , , , , CC: , , , , , , , , , , Date: Thu, 23 Jun 2022 11:34:09 +0800 In-Reply-To: <3246fb94ec05a43b7017849198d949ce8c8636a7.camel@mediatek.com> References: <20220621113732.11595-1-rex-bc.chen@mediatek.com> <20220621113732.11595-13-rex-bc.chen@mediatek.com> <55c98626-9b95-7721-94cf-8c471580a53b@collabora.com> <3246fb94ec05a43b7017849198d949ce8c8636a7.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-06-22 at 17:08 +0800, Rex-BC Chen wrote: > On Tue, 2022-06-21 at 14:11 +0200, AngeloGioacchino Del Regno wrote: > > Il 21/06/22 13:37, Bo-Chen Chen ha scritto: > > > MediaTek dpi supports direct connection to pins while dp_intf > > > does > > > not > > > support. Therefore, add a config "support_direct_pin" to control > > > this. > > > > > > Signed-off-by: Bo-Chen Chen > > > --- > > > drivers/gpu/drm/mediatek/mtk_dpi.c | 17 +++++++++++++---- > > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > > > b/drivers/gpu/drm/mediatek/mtk_dpi.c > > > index 438bf3bc5e4a..ef7f828a4b1e 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > > > @@ -129,6 +129,8 @@ struct mtk_dpi_yc_limit { > > > * @is_ck_de_pol: Support CK/DE polarity. > > > * @swap_input_support: Support input swap function. > > > * @color_fmt_trans_support: Enable color format transfer. > > > + * @support_direct_pin: Dpi can directly connect pins, and > > > enable > > > this config > > > + * to do this. > > > > @support_direct_pin: IP supports direct connection to pins > > > > or > > > > @support_direct_pin: IP has direct connection to DP pins > > > > or > > > > @support_direct_pin: IP connects directly to DP pins > > > > pick one, after which: > > > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > > > > > Hello Angelo, > > this is not connect to "DP" pin. This setting is for dpi to connect > to > panel directly and there is no such usecase for dp_intf. > > Therefore, I will use "@support_direct_pin: IP supports direct > connection to pins". > > Thanks > > BRs, > Bo-Chen > Hello Angelo, I think "@support_direct_pin: IP supports direct connection to dpi panels" is more precise for this config. I will use this description. BRs, Bo-Chen