From: Ian Abbott <abbotti@mev.co.uk>
To: Arash Fotouhi <arash@arashfotouhi.com>
Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
olsonse@umich.edu, giulio.benetti@micronovasrl.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: ni_mio_common.c: Added blank line after declarations
Date: Fri, 22 Mar 2019 10:32:14 +0000 [thread overview]
Message-ID: <0c2aeba6-5791-3787-2a08-e4bdd4ea0cd0@mev.co.uk> (raw)
In-Reply-To: <1553195892-40323-1-git-send-email-arash@arashfotouhi.com>
On 21/03/2019 19:18, Arash Fotouhi wrote:
> Added blank line after declarations.
>
> Signed-off-by: Arash Fotouhi <arash@arashfotouhi.com>
> ---
> drivers/staging/comedi/drivers/ni_mio_common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index 5edf59a..c6aff8f 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -2110,6 +2110,7 @@ static int ni_ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
>
> if (cmd->scan_begin_src == TRIG_TIMER) {
> unsigned int tmp = cmd->scan_begin_arg;
> +
> cmd->scan_begin_arg =
> ni_timer_to_ns(dev, ni_ns_to_timer(dev,
> cmd->scan_begin_arg,
> @@ -2120,6 +2121,7 @@ static int ni_ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
> if (cmd->convert_src == TRIG_TIMER) {
> if (!devpriv->is_611x && !devpriv->is_6143) {
> unsigned int tmp = cmd->convert_arg;
> +
> cmd->convert_arg =
> ni_timer_to_ns(dev, ni_ns_to_timer(dev,
> cmd->convert_arg,
>
Looks good, thanks.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
prev parent reply other threads:[~2019-03-22 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 19:18 Arash Fotouhi
2019-03-22 10:32 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c2aeba6-5791-3787-2a08-e4bdd4ea0cd0@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=arash@arashfotouhi.com \
--cc=devel@driverdev.osuosl.org \
--cc=giulio.benetti@micronovasrl.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olsonse@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®