From: Jon Hunter <jonathanh@nvidia.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Ogness <john.ogness@linutronix.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Petr Mladek" <pmladek@suse.com>,
"Thierry Reding" <thierry.reding@kernel.org>,
linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Crescent Hsieh" <crescentcy.hsieh@moxa.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
linux-serial@vger.kernel.org,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH tty 1/1] serial: 8250: Change console_msr_work to IRQ_WORK_LAZY
Date: Fri, 28 Aug 2026 18:06:50 +0100 [thread overview]
Message-ID: <0c2c424f-0372-4626-b14e-7697d98e6b20@nvidia.com> (raw)
In-Reply-To: <20260828160652.TQBsi8oO@linutronix.de>
On 28/08/2026 17:06, Sebastian Andrzej Siewior wrote:
> On 2026-08-28 18:04:08 [+0206], John Ogness wrote:
>> For some platforms it is a problem to queue irq_work when entering
>> cpuidle states. Since irq_work is used for deferred MSR handling,
>> any atomic console printing when entering cpuidle states can lead
>> to the affected hardware hanging. Tegra20 and Tegra30 are examples
>> of such platforms. Avoiding raising the irq_work IRQ has shown to
>> circumvent the problem.
>
> I would argue that this is done for the benefit of less interrupts since
> there no need to handle console_msr_work immediately. With the side
> effect that it might fix a bug that was not yet reported on Tegra[23]0.
>
> Ideally the Tegra folks should figure out what exactly is broken instead
> of adding duct tape everywhere else.
Yes that would be ideal. Unfortunately these are old devices now and very
much in maintenance mode so getting to the bottom of this now is unlikely.
You may say then why don't we completely deprecate these, but then you
could argue the other way and say they have been working fine up until
now.
Jon
--
nvpublic
prev parent reply other threads:[~2026-08-28 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 15:58 [PATCH tty 0/1] Make 8250 deferred MSR handling LAZY John Ogness
2026-08-28 15:58 ` [PATCH tty 1/1] serial: 8250: Change console_msr_work to IRQ_WORK_LAZY John Ogness
2026-08-28 16:06 ` Sebastian Andrzej Siewior
2026-08-28 16:41 ` John Ogness
2026-08-28 17:06 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c2c424f-0372-4626-b14e-7697d98e6b20@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=crescentcy.hsieh@moxa.com \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®