From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2371156F45 for ; Mon, 4 May 2026 04:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777867323; cv=none; b=fTW3bayxouA5HPSB0V8mVn5uS8l6jkq8Y0C7Ycb3Gtsq/a5QCDpuQ60kVHgDRACb/dUkx2fpsx5ef5DDemQPdFbCjk8Cs1p3a/NM/t99KDqvy6bRoCfcS3/G4e0oGZMNtCSk4/KdM8CpXjD916hSEecbaLas+Y1z3JaLPuc6cms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777867323; c=relaxed/simple; bh=3P9PTGXQEqceejzlt4oB6hCgg6/9NoHPJVWEt1XjDfk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C4cX61UmjNYSNablIa+0ZgPYZWUQNOnWrBiFirMI5ndMXHTdYqdgMg+B35zUnhCaL+ZMxbE+7cE8KhcneE2yX+q5/9xdC7JjAASCJG4c9L5VH+CZri6P7E8s5ICG1VhznYCZkIex/alwz49Bwmd0pq7dwv4IL5l3SWeljw9IO6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FA2GdEA7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ahR74mpf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FA2GdEA7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ahR74mpf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777867320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m+5Um6TFBnBOiuOAmXBNCCA71a07CLbH3rgRCp2jTGs=; b=FA2GdEA7AU/UDp2rn9uFbP+1jdZL+jIkHxnneE4Ae/dhkbGW2E2utdJTGuJMihjCQD7ahv 3mr2Vw2erEkskoAWTTsZo5Cn/69S1zQ2v23cBsuRIdtAbQ/dWONr3hYFOZ+0HpbrOKk3L7 eQHBm87lIUZ+bTxAp8tsWVi9OdDs7W8= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573-6q6fpuShNXW8kEIqMmDzgQ-1; Mon, 04 May 2026 00:01:59 -0400 X-MC-Unique: 6q6fpuShNXW8kEIqMmDzgQ-1 X-Mimecast-MFC-AGG-ID: 6q6fpuShNXW8kEIqMmDzgQ_1777867319 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-7bd5c9e1826so13042957b3.1 for ; Sun, 03 May 2026 21:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777867319; x=1778472119; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m+5Um6TFBnBOiuOAmXBNCCA71a07CLbH3rgRCp2jTGs=; b=ahR74mpfjikES/sgx6xLa/BlnQXifJ4h6HXe6qLXrKtEC+bL/gABxFJjjNfMC+/5/+ nLzFjIYylBjQS6n19zZio8rwBbMNlVLjdJCyUuOPC4QnmMrzjdclBu7n1gQoAspU1ceb tTrQOPRRr5ZBbRvkiy1c4gyyh7HMuhVAfJf0cW2ewvvT5HWPyI2ucfpBcTGTJW4YoYrK Ciqn3wQbO6iQaR3BbY74WB2sf/sIWETkuMl5SDK/HhynLdPK4WMSldCyOr6+DnDEiSc1 mOAI6eEsXjYjx5x+CEPn1RhuLqLNo52XiK2DxOB3sebtOzUgUWZeEpLkszuiyy+lDtF2 lDjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777867319; x=1778472119; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m+5Um6TFBnBOiuOAmXBNCCA71a07CLbH3rgRCp2jTGs=; b=bPO6kl+4jthtSEWp0w4MxQaKhmNZj6lEmSoQYxJJy2sVV81zNRoF+yiRMbeDWuQPWA UeDetTeD/hJZAgedfkAkuIWZHfipD/+VfXqvutsoROcJRbllkHpL8kbloYcphyTBeNaP jub329YgJrKEs+As8tXaFEsKV2lQluGtRnttlrljpAz6rMKGXG8PtHaYSn+UBIm8A0Tq rwCP6fd+x3YGsWNK1bY7T/YdL5Oty2tYiqXAIrl52RMrt/0V7+7z8zGyIay9I4GHRZvE /s6HoShKLo45kxwzoHzxx1ZyZOR8OPmtcVNVGOWpybFaB+h0v9q+bB3wQrZZnC1nVIg5 eh0w== X-Forwarded-Encrypted: i=1; AFNElJ/h+EVw/NxNZQpY9URzLU+3lalBPmQB/k3qkAzov9mTiS058IMm4UvbdNOeynBnhob1970Qd+fwsO5hoeI=@vger.kernel.org X-Gm-Message-State: AOJu0YyhOB6HP/r1/iDHvZDWC69Bm+ZxxSexjR1Z3rskm76YzgFqJObH rN1Inr4OUF45MVYsGDx6PfsKg+DB14Wa94Ok2RD3UcPnpFNpvy+q0ov+O8lCEv5cspqZPC3vztI ABu37JpOZfoSBUbOgBjs2ccZqMGPz4FiEucZ7WvS968SyeQf0qfGf7/TjMOdqllyaAQ== X-Gm-Gg: AeBDievUViuLHrGftWJ+GQCPKFz1119blPpy01ULljmRBNYsBFwX5RzC6PiKcCFJj9K bHNLp6aYmlv3wyF9rbToB4sXAapDkkbkDvQkAwbtfUmBoAvQbdqBDnBq6R07ToHoUSpGSBQoEco bf+AUNYIruvQk+dpfxDXKBZ8UIYw3d3qisKgqIwWBcfUcuzZNkK+iSTkP01rMueK+Ao1OWmpnuE EiL8wgGtpBxB/Ug/uhoVDbJE4IRq9gXHgSlNdYZfAO7+vMFzp46c4G3Gf9GubzOugNIZiKehLiL AG3I/r/aV0/Y666yUb+nS6FCvnfyuBdiRppNtUdeEiPRSgbtDJeZIVHLLHFIR4/FcDonS4esxaV +v/V6mTmd56FK/snlIk4kKNI4NaWuhEi53iUajU2YE6JkvEAXBJtssYID491EFXbDjzI= X-Received: by 2002:a05:690c:289:b0:79a:b440:5c8d with SMTP id 00721157ae682-7bd76928ceamr64734277b3.11.1777867318928; Sun, 03 May 2026 21:01:58 -0700 (PDT) X-Received: by 2002:a05:690c:289:b0:79a:b440:5c8d with SMTP id 00721157ae682-7bd76928ceamr64734087b3.11.1777867318535; Sun, 03 May 2026 21:01:58 -0700 (PDT) Received: from [192.168.178.105] (78-0-206-107.adsl.net.t-com.hr. [78.0.206.107]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd6654e464sm44456777b3.14.2026.05.03.21.01.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 May 2026 21:01:58 -0700 (PDT) Message-ID: <0c385b67-035a-4f66-8f3a-febd68a9318b@redhat.com> Date: Sun, 3 May 2026 22:02:30 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/14] mm: remove READ_ONLY_THP_FOR_FS Kconfig option To: Zi Yan , Andrew Morton , David Hildenbrand , "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20260429152924.727124-1-ziy@nvidia.com> <20260429153538.727855-1-ziy@nvidia.com> Content-Language: en-US From: Nico Pache In-Reply-To: <20260429153538.727855-1-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/29/26 9:35 AM, Zi Yan wrote: > After removing READ_ONLY_THP_FOR_FS check in file_thp_enabled(), > khugepaged and MADV_COLLAPSE can run on FSes with PMD THP pagecache > support even without READ_ONLY_THP_FOR_FS enabled. Remove the Kconfig first > so that no one can use READ_ONLY_THP_FOR_FS as upcoming commits remove > mapping->nr_thps, which its safe guard mechanism relies on. > > Signed-off-by: Zi Yan > Reviewed-by: Lorenzo Stoakes (Oracle) > Acked-by: David Hildenbrand (Arm) > Reviewed-by: Baolin Wang > --- > mm/Kconfig | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index e221fa1dc54d0..27dc5b0139ba6 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -936,17 +936,6 @@ config THP_SWAP > > For selection by architectures with reasonable THP sizes. > > -config READ_ONLY_THP_FOR_FS Yay its gone! Thanks for working on this :) Reviewed-by: Nico Pache > - bool "Read-only THP for filesystems (EXPERIMENTAL)" > - depends on TRANSPARENT_HUGEPAGE > - > - help > - Allow khugepaged to put read-only file-backed pages in THP. > - > - This is marked experimental because it is a new feature. Write > - support of file THPs will be developed in the next few release > - cycles. > - > config NO_PAGE_MAPCOUNT > bool "No per-page mapcount (EXPERIMENTAL)" > help