From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEFAA3002A0 for ; Tue, 3 Feb 2026 23:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160787; cv=none; b=qUn8p52PfIuK0IdJTYJ3XJSmnL3XLCnSW4znHtvn1pWtI1Q0vLx1gy+AIjfDaYETpUQNZJyWrUGgZlYkRhaLGnNKMT1sMAdJC3jj+wdWZXb2HIe8w0aS8VxSVHhoXT/w1VObAes4woguYJFV048fJIXmw8ywo/LdyvtH8dlsGU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160787; c=relaxed/simple; bh=QmJIRkoJvSC1+X5XmHnKi501SEuHKyJrim2KrRQ9zFg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=slppaDK9rQj7A0gh6lwJGx7frFE+pI3z93rvzSIrfHRecL/ehRvFZfc/+g8I931dsuulCL0Lv5DJvH2oUpTL9CWg6aPjACMRqG+awkPySAtuWwZUXrXSQo5a5TvIxr/476nydQGRNLz/w0hKdYKw9Cll6I7gKnmE+Y0mN4wP/CA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BZ+bG4DI; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BZ+bG4DI" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-481188b7760so1126185e9.0 for ; Tue, 03 Feb 2026 15:19:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770160783; x=1770765583; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nUf/+8BbxtoTRhkrLvjqMjX8iWnPM8A43bKR4Om6EwE=; b=BZ+bG4DIorv3Ms/VAg1NzEFZ9dK0XKKnWYUFIoEjjsTpLTi6DGrMlEw3ptbVClWDKS 6ueTSgQgEvee72itnYjh6LkSB2u0NBM07EpK+KKlDkbwUf73M3R2nSPR/5l/C4xycTh/ WKofmE121djfiy+TaVV4UXI/GAhV9SvobJOPdmO6fIDNxBFyIN0c64tOD5zxHt0xPNrU LymDtom+q9w3cgKhYHTewqGxqTtrwy1Fk2wGqkCwVlFqtjy+g1/5niKy5KqRFp/2zt/h 4ilr/Y8BFT4RAXnmDyHWgQ/Jxoancq4ShpxKcOl1p74XU9ecVnFJ43f+HxokvG26fmCV VLqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770160783; x=1770765583; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nUf/+8BbxtoTRhkrLvjqMjX8iWnPM8A43bKR4Om6EwE=; b=jz3og/zlCNyOxX6X8K//ZHDKBo+jKf13qIPFu3v8olrDbs2Iq08Qg4goxG5vUB15ht G087hYoKoJ6SW+HVdhSj3TGOXW1v/xy/A9WU39Huq0YObvhCcH+bUjBTIOOXtTbqNPKd ya+IrN4ZtcyHGn2pu/DepCDfiQJyfAVyVCDz3LahmqAx4Z2XUm4Z9VjshuIxzm2ibpFY ugJq48cCFhdQTQ3ZmS5gZJ7CrrVi64l+ivOzgYLaoZoTVyeR7uL/+JvkTs5aL5f/xBZh FyFaPX2G9HxmNFZoCazhwWwL3AwI/ESYDXAVpLLr/XRTwY48nFjxktkQ2oxrBQz9/0bV bNWA== X-Forwarded-Encrypted: i=1; AJvYcCVVoEjoKKyoe8jRgEyeu2uCqCHZuZMtJsP2ZqxY93MBifLl+9AqwB6S9l+8A2dRjKTXVFzxM//qh6oXm1M=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp1JK6j4a83YsIcLJF+QfnXLxh3EkiavChp7YLtVfS5vd7vLd1 VB4YPiJnNfaA7Znokg0+VFRTfml6e0ushpzlQaBCAA+1GSAdXMPMMlEs4tbbvZa9Bko= X-Gm-Gg: AZuq6aIbKmaIh0WNOlpoLqk8/llFF4yGpGB81H8gAZh9gBhAa3RsV3UyyVh6aw3HCDu V/V6hwNlR1T6e5QrHXhTqNiA2Zy4NsX87SUABbiqe8H9PGFKrOXwr1M1psuQyW/I9PTy23KUVfh JlGOC+CnnPDM4Mv6tddMyI1/Q7IjkMQ9PXCdDgAaSdHIoeGJtW6XsL6IDsw1tNhlTHLbryuzOEn C3ialwg3iT7Bu6LjqIhjHzmiaHnewq49Kk41yzmW+tsB9k9QFdpAZODw8WC851CkUIEN9budi3Q C3ILrpvOeRu9DrKSGMrwn/g75ZypM+Wqdv0m2B3HyI1wrmzVMrUbqqlFBAZ/KRtwDfrXW+XSka1 CzPi6awHRJSkzgA3gnlbK4oGwLtQJsDXwz2Ok4OGH60cF9TbYHOXDECVV7SE04gsKcJZtZQ+Jhy FcNVr7uXmafVeNNIi4F27aszVai/wb03tHB0K1+EA4blFWX8PmxxT8 X-Received: by 2002:a05:600c:1c17:b0:480:5951:fc1e with SMTP id 5b1f17b1804b1-4830e930f73mr17628865e9.11.1770160783238; Tue, 03 Feb 2026 15:19:43 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483108ec315sm2221095e9.8.2026.02.03.15.19.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 15:19:42 -0800 (PST) Message-ID: <0c3acd1c-5860-4819-9b36-6935137deea8@linaro.org> Date: Tue, 3 Feb 2026 23:19:39 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] dt-bindings: clock: qcom,sm8250-videocc: account for the MX domain To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260201-iris-venus-fix-sm8250-v2-0-6f40d2605c89@oss.qualcomm.com> <20260201-iris-venus-fix-sm8250-v2-1-6f40d2605c89@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260201-iris-venus-fix-sm8250-v2-1-6f40d2605c89@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/02/2026 10:48, Dmitry Baryshkov wrote: > To configure the video PLLs and enable the video GDSCs on SM8250, > platform, the MX rail must be ON along with MMCX. Split the bindings > file in order to provide separate file utilizing MMCX and MX power > domains. > > Fixes: dafb992a95e1 ("dt-bindings: clock: add SM8250 QCOM video clock bindings") > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/clock/qcom,sm8250-videocc.yaml | 85 ++++++++++++++++++++++ > .../devicetree/bindings/clock/qcom,videocc.yaml | 20 ----- > 2 files changed, 85 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8250-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8250-videocc.yaml > new file mode 100644 > index 000000000000..341d3cbb7cbb > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8250-videocc.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,sm8250-videocc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Video Clock & Reset Controller > + > +maintainers: > + - Taniya Das > + > +description: | > + Qualcomm video clock control module provides the clocks, resets and power > + domains on Qualcomm SoCs. > + > + See also:: > + include/dt-bindings/clock/qcom,videocc-sm8250.h > + > +properties: > + compatible: > + oneOf: > + - enum: > + - qcom,sm8250-videocc > + > + clocks: > + items: > + - description: AHB > + - description: Board XO source > + - description: Board active XO source > + > + clock-names: > + items: > + - const: iface > + - const: bi_tcxo > + - const: bi_tcxo_ao > + > + power-domains: > + items: > + - description: > + A phandle and PM domain specifier for the MMCX power domain. > + - description: > + A phandle and PM domain specifier for the MX power domain. > + > + required-opps: > + items: > + - description: > + A phandle to an OPP node describing required MMCX performance point. > + - description: > + A phandle to an OPP node describing required MX performance point. > + > +required: > + - compatible > + - clocks > + - clock-names > + - '#power-domain-cells' > + - power-domains > + - required-opps > + > +allOf: > + - $ref: qcom,gcc.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + clock-controller@ab00000 { > + compatible = "qcom,sm8250-videocc"; > + reg = <0x0ab00000 0x10000>; > + clocks = <&gcc_gcc_video_ahb_clk>, > + <&rpmhcc RPMH_CXO_CLK>, > + <&rpmhcc RPMH_CXO_CLK_A>; > + clock-names = "iface", > + "bi_tcxo", > + "bi_tcxo_ao"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + power-domains = <&rpmhpd RPMHPD_MMCX>, > + <&rpmhpd RPMHPD_MX>; > + required-opps = <&rpmhpd_opp_low_svs>, > + <&rpmhpd_opp_low_svs>; > + }; > +... > diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > index f4ff9acef9d5..8676c7e22b4c 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > @@ -19,7 +19,6 @@ description: | > include/dt-bindings/clock/qcom,videocc-sc7280.h > include/dt-bindings/clock/qcom,videocc-sdm845.h > include/dt-bindings/clock/qcom,videocc-sm8150.h > - include/dt-bindings/clock/qcom,videocc-sm8250.h > > properties: > compatible: > @@ -30,7 +29,6 @@ properties: > - qcom,sdm845-videocc > - qcom,sm6350-videocc > - qcom,sm8150-videocc > - - qcom,sm8250-videocc > - items: > - const: qcom,sc8180x-videocc > - const: qcom,sm8150-videocc > @@ -128,24 +126,6 @@ allOf: > - const: iface > - const: bi_tcxo > > - - if: > - properties: > - compatible: > - enum: > - - qcom,sm8250-videocc > - then: > - properties: > - clocks: > - items: > - - description: AHB > - - description: Board XO source > - - description: Board active XO source > - clock-names: > - items: > - - const: iface > - - const: bi_tcxo > - - const: bi_tcxo_ao > - > unevaluatedProperties: false > > examples: > > -- > 2.47.3 > > Reviewed-by: Bryan O'Donoghue