mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
	agross@kernel.org, andersson@kernel.org, djakov@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	quic_tsoni@quicinc.com, quic_shashim@quicinc.com,
	quic_kaushalk@quicinc.com, quic_tdas@quicinc.com,
	quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com,
	kernel@quicinc.com
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add SM4450 interconnect provider driver
Date: Wed, 20 Sep 2023 12:31:19 +0200	[thread overview]
Message-ID: <0c3bc9d9-6c67-a025-ce86-82385794bd68@linaro.org> (raw)
In-Reply-To: <73a90202-1127-4469-a46d-7986343c51b1@quicinc.com>



On 9/19/23 03:59, Tengfei Fan wrote:
> 
> 
> 在 9/15/2023 8:43 PM, Konrad Dybcio 写道:
>> On 15.09.2023 04:01, Tengfei Fan wrote:
>>> Add driver for the Qualcomm interconnect buses found in SM4450 based
>>> platforms. The topology consists of several NoCs that are controlled
>>> by a remote processor that collects the aggregated bandwidth for each
>>> master-slave pairs.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>> [...]
>>
>>> +static struct qcom_icc_bcm bcm_acv_disp = {
>>> +    .name = "ACV",
>>> +    .num_nodes = 1,
>>> +    .nodes = { &ebi_disp },
>>> +};
>>> +
>>> +static struct qcom_icc_bcm bcm_mc0_disp = {
>>> +    .name = "MC0",
>>> +    .num_nodes = 1,
>>> +    .nodes = { &ebi_disp },
>>> +};
>>> +
>>> +static struct qcom_icc_bcm bcm_mm0_disp = {
>>> +    .name = "MM0",
>>> +    .num_nodes = 1,
>>> +    .nodes = { &qns_mem_noc_hf_disp },
>>> +};
>>> +
>>> +static struct qcom_icc_bcm bcm_sh0_disp = {
>>> +    .name = "SH0",
>>> +    .num_nodes = 1,
>>> +    .nodes = { &qns_llcc_disp },
>>> +};
>>> +
>>> +static struct qcom_icc_bcm bcm_sh1_disp = {
>>> +    .name = "SH1",
>>> +    .num_nodes = 1,
>>> +    .nodes = { &qnm_pcie_disp },
>>> +};
>> """
>> v1 -> v2:
>>    - remove DISP related paths
>> """
>>
>> you sure?
>>
>> + I still see _disp nodes..
>>
>> Konrad
> 
> Hi Konrad,
> only removed SLAVE_MNOC_HF_MEM_NOC_DISP related code actually as V1 
> comment.
No, I asked you to remove all nodes that only exist to access
non-APPS_RSC BCMs

Konrad

      reply	other threads:[~2023-09-20 10:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  2:01 [PATCH v2 0/2] interconnect: qcom: Add SM4450 interconnect Tengfei Fan
2023-09-15  2:01 ` [PATCH v2 1/2] dt-bindings: interconnect: Add Qualcomm SM4450 Tengfei Fan
2023-09-15  3:13   ` Rob Herring
2023-09-15  7:17   ` Krzysztof Kozlowski
2023-09-15  7:26     ` Tengfei Fan
2023-09-15  2:01 ` [PATCH v2 2/2] interconnect: qcom: Add SM4450 interconnect provider driver Tengfei Fan
2023-09-15 12:43   ` Konrad Dybcio
2023-09-19  1:59     ` Tengfei Fan
2023-09-20 10:31       ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c3bc9d9-6c67-a025-ce86-82385794bd68@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=kernel@quicinc.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_aiquny@quicinc.com \
    --cc=quic_kaushalk@quicinc.com \
    --cc=quic_shashim@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=quic_tengfan@quicinc.com \
    --cc=quic_tingweiz@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®