From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f42.google.com (mail-dy2-f42.google.com [74.125.229.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBDFA2DE709 for ; Mon, 5 Oct 2026 03:48:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791172090; cv=none; b=XrAIJXVgc3hjAhNoYQvMI5sLzjQqKfcd/30EnWJmCJvvrrYkKV5G7xFl5sttiD4cENlK2KTzYYPTMPglADvqb5DCK5H813ilEaIb32oYrVKpTDRUAVARWNt60v5r5TYNRc5FCBlXQS8tCnFqqiiAbZgw1uap5UaXxE9d0hWUdKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791172090; c=relaxed/simple; bh=r5A4UZPux5Y3nKltnaBqnFx1Wecjg4H7ieud878T3Vw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dcas2B190yTqREGc4lPXFe/HUQ4VMW6tX4uA3DZPV8OZXaHMdC8cEDRz/fL/50IGdtUA3GqS8D0p7LPxVfYNVujzD3fKhIunU58YOKa1eekIKthGjeCER3P9Q6RjgTipC7emF+tBN6XwDnkzdaFy1uq/wDESZmk9QyUXjgWVcEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d6zsiM+M; arc=none smtp.client-ip=74.125.229.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d6zsiM+M" Received: by mail-dy2-f42.google.com with SMTP id 5a478bee46e88-3512f0ac09bso407650eec.1 for ; Sun, 04 Oct 2026 20:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791172088; x=1791776888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=We84JRc/bHqMhmFuiHMoH3sRnXvkHgWbYpO/4GVf6wY=; b=d6zsiM+M857v2SPpIeD95uGfCMYk/ib84cNTJyb/OlhOAU7p7E5W5dUCGP4z1j4X8i RnNrJUGDIdzkcdsIHL61H9j7xw2v/cekCsl36asU793f69Sl0uVFmJB46EAwxspefM5c cQTMXC5a0BEpXXhfm/VZM9hKZPLJhPnxezOC0Jk1YIErJ51PPM3uSgSMoKfWMoWE6lgb uSXeklr1J6Gg6rTN0XeT99a16t23gIgEn78rYcsJh4hzEbOydu07rtKCKVwFLa4hSQ0J gY14zSVVD/KVSIDcGolys6OpRMZh1yqsL08G8Uc+8As4LIeS1wTA4h3KE7gNC0BfB6tM CFoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791172088; x=1791776888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=We84JRc/bHqMhmFuiHMoH3sRnXvkHgWbYpO/4GVf6wY=; b=K22k41bzr9aA0s9tbw0IqrRCeB04AE7BiH1+39+5b59p9IceAVSYqNDtGheqISqAaE Z5weaRGbZ8IzedWe35iwwowFKE4LWQuBvwf9ztswXOWQcN/BhRI4l4BUEkLtmIoXjEsD mj6D/c8AotvNp6HLEm495mrIhoaq24i4/OMwi5Zs6rOVOremRCwCMedakMEDJncNhXEe ZdLJbUxvfFXp8m3Odl+RBk4r8KOYDcoVeLKD9qomCCBtE1Uyf601INFnqP+bfdF4/feR 5YHsmB+5pqylGmCuF7gVwj98UIx03anvUAYhrQZKOVFHKq7foao8VDx30ztkK7rPx5O6 qfEA== X-Forwarded-Encrypted: i=1; AKwUvBxx0RcYVDX0kR6qbftZHwPv5jvfmq5+gpD9Ho571JJxyc6WIEO7KFn0Tvt8oblpoXukTB9cY81UWhIi8s0=@vger.kernel.org X-Gm-Message-State: AFq9FYJyfhv9zrPkF2y0YayiK0eEdttux9NXv4UI0DesQUOO+onwASHR 55kY1IDJ/tzLPga7mhWa2HpeobNgqZhv0Pmc/spuZQq6zX3DRL2uYNt0 X-Gm-Gg: AYBFou1kzgR+NdROG4gZVy3Ldx8PdPODMDgWZ/Ad0AsmwTXXKZjUrmq3e6LW9UKMJyx wDWglcMncxHovQrpGjyFDArLcFLL33V9qWdH8aN4neRLovMl6LsqBtgrI3sE6TJlpitt1gficCd YtDOBJeE8vh9fun/c5msRdQwmGV8gSoSK755FjKjaPYu5Tm6WjMa6hpJsa5duPBAfjkIxxcyros qxdtDk4taikA7XauLU7l8qXDuyGSX0IU4YfFsCzwIrfAN/oZCxP7cRHRFAtP7Fnc/A90Mv6l/Df FLgiHfWEGGTU9ABvr0qtToaPa5iAIIPcszDkJZBF3wG6by1MlyETgTA36Ls1x230UeHe6Ve4h6e LWgZdULAHJvFtyTXH1MXvIWR6sTj9arE6/Z13Qc+MYlx7gNryCGDUCMlvo1Goa37PiVmVH7V9wQ dxeC9cNY+hh9ItVE+EZeAHYXP2TbyyZU/9TmP3/b6Kk7r1C6BCBHt5NeLK4IdONm+n+Sa8gXEID dr3klk7ESrfip+aMw/uf+mybvhZlQ7kLOPBSQt6lMcZsg+QJYPJajdPvXlE X-Received: by 2002:a05:7301:707:b0:34a:e4f6:4a4b with SMTP id 5a478bee46e88-34f150c3c64mr10761322eec.21.1791172087608; Sun, 04 Oct 2026 20:48:07 -0700 (PDT) Received: from pve-server.rlab ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3512718a18esm10840958eec.17.2026.10.04.20.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2026 20:48:07 -0700 (PDT) From: "Ritesh Harjani (IBM)" To: kvm@vger.kernel.org, Sean Christopherson Cc: Paolo Bonzini , linuxppc-dev@lists.ozlabs.org, Michael Ellerman , Christophe Leroy , Anushree Mathur , Venkat Rao Bagalkote , Harsh Prateek Bora , Madhavan Srinivasan , Shrikanth Hegde , linux-kernel@vger.kernel.org, "Ritesh Harjani (IBM)" Subject: [PATCH v6 5/5] KVM: selftests: Don't limit LE dirty-bitmap bitops to s390x Date: Mon, 5 Oct 2026 09:17:28 +0530 Message-Id: <0c3cf7d492acb9da38bcdd0331cb69929c947c30.1791014924.git.ritesh.list@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit dirty_log_test already has BITOP_LE_SWIZZLE helpers, but they were compiled in only for s390x, so every other big-endian host used native test_bit(). The test fails on big-endian powerpc because it treated dirty host pages as clean (because of the endianness issue) w/o the fix the test fails with: Clear page 1 value (1) >= iteration (1) Tested-by: Anushree Mathur Signed-off-by: Ritesh Harjani (IBM) --- tools/testing/selftests/kvm/Makefile.kvm | 1 + tools/testing/selftests/kvm/dirty_log_test.c | 12 ++++-------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 57d1bf994fe8..38c350c5b5e3 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -264,6 +264,7 @@ TEST_GEN_PROGS_powerpc += set_memory_region_test TEST_GEN_PROGS_powerpc += memslot_modification_stress_test TEST_GEN_PROGS_powerpc += memslot_perf_test TEST_GEN_PROGS_powerpc += access_tracking_perf_test +TEST_GEN_PROGS_powerpc += dirty_log_test SPLIT_TESTS += arch_timer SPLIT_TESTS += get-reg-list diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c index af5eb0334a74..8189eaac713c 100644 --- a/tools/testing/selftests/kvm/dirty_log_test.c +++ b/tools/testing/selftests/kvm/dirty_log_test.c @@ -44,8 +44,11 @@ #define TEST_MIN_WRITES_PER_ITERATION 0x100 /* Dirty bitmaps are always little endian, so we need to swap on big endian */ -#if defined(__s390x__) +#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ # define BITOP_LE_SWIZZLE ((BITS_PER_LONG-1) & ~0x7) +#else +# define BITOP_LE_SWIZZLE 0 +#endif # define test_bit_le(nr, addr) \ test_bit((nr) ^ BITOP_LE_SWIZZLE, addr) # define __set_bit_le(nr, addr) \ @@ -56,13 +59,6 @@ __test_and_set_bit((nr) ^ BITOP_LE_SWIZZLE, addr) # define __test_and_clear_bit_le(nr, addr) \ __test_and_clear_bit((nr) ^ BITOP_LE_SWIZZLE, addr) -#else -# define test_bit_le test_bit -# define __set_bit_le __set_bit -# define __clear_bit_le __clear_bit -# define __test_and_set_bit_le __test_and_set_bit -# define __test_and_clear_bit_le __test_and_clear_bit -#endif #define TEST_DIRTY_RING_COUNT 65536 -- 2.39.5