答复: [外部邮件] Re: (subset) [PATCH] fs: Make file-nr output the total allocated file handles

["Li,Rongqing" <lirongqing@baidu.com>]

> On Thu, 10 Apr 2025 19:21:17 +0800, lirongqing wrote:
> > Make file-nr output the total allocated file handles, not per-cpu
> > cache number, it's more precise, and not in hot path
> >
> >
> 


Hi Christian Brauner:

Could we change the changelog as below, it maybe more reasonable

    fs: Use percpu_counter_sum_positive in proc_nr_files

    The centralized value of percpu counter can be really grossly inaccurate
    as CPU count increases. and proc_nr_files is only accessed when reading
    proc file, not a hot path, so use percpu_counter_sum_positive in it, to make
    /proc/sys/fs/file-nr more accurate

thanks


-Li

> Applied to the vfs-6.16.misc branch of the vfs/vfs.git tree.
> Patches in the vfs-6.16.misc branch should appear in linux-next soon.
> 
> Please report any outstanding bugs that were missed during review in a new
> review to the original patch series allowing us to drop it.
> 
> It's encouraged to provide Acked-bys and Reviewed-bys even though the patch
> has now been applied. If possible patch trailers will be updated.
> 
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs-6.16.misc
> 
> [1/1] fs: Make file-nr output the total allocated file handles
>       https://git.kernel.org/vfs/vfs/c/66319519f89d