mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] microblaze: use the common infrastructure to support built-in DTB
Date: Fri, 8 Nov 2024 12:53:53 +0100	[thread overview]
Message-ID: <0c4dc285-f218-4c88-87f3-b7c7c786cdba@monstr.eu> (raw)
In-Reply-To: <20240918045431.607826-1-masahiroy@kernel.org>



On 9/18/24 06:52, Masahiro Yamada wrote:
> MicroBlaze is the only architecture that supports a built-in DTB in
> its own way.
> 
> Other architectures (e.g., ARC, NIOS2, RISC-V, etc.) use the common
> infrastructure introduced by commit aab94339cd85 ("of: Add support for
> linking device tree blobs into vmlinux").
> 
> This commit migrates MicroBlaze to this common infrastructure.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
> I do not know why MicroBlaze still adopts its own way.
> Perhaps, because MicroBlaze supports the built-in DTB
> before aab94339cd85 and nobody attempted migration.
> Anyway, I only compile-tested this patch.
> I hope the maintainer can do boot-testing.


I took a look at it and it is changing current behavior.
If you look at linux.bin and there is no DT inside. But when you patch is 
applied linux.bin contains system.dtb inside which is regression.
Or is it intention of this patch?

I think there was any documentation about it's usage in past but never really 
described in upstream kernel.
But idea was that linux.bin requires DT to be passed from bootloader via R7 reg 
but simpleImage.X is linux.bin+DTB inside and can be used without bootloader.

Thanks,
Michal




  parent reply	other threads:[~2024-11-08 11:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18  4:52 Masahiro Yamada
2024-11-06 16:50 ` Masahiro Yamada
2024-11-08 11:53 ` Michal Simek [this message]
2024-11-08 17:27   ` Masahiro Yamada
2024-11-15 10:14     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c4dc285-f218-4c88-87f3-b7c7c786cdba@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®