From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>, <roopa@nvidia.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<bridge@lists.linux-foundation.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/bridge: Fix inconsistent format argument types
Date: Wed, 13 Jan 2021 14:33:10 +0200 [thread overview]
Message-ID: <0c4ef6ac-3d6f-121a-51bd-1abed4a75da4@nvidia.com> (raw)
In-Reply-To: <1610531059-56212-1-git-send-email-abaci-bugfix@linux.alibaba.com>
On 13/01/2021 11:44, Jiapeng Zhong wrote:
> Fix the following warnings:
>
> net/bridge/br_sysfs_if.c(162): warning: %ld in format string (no. 1)
> requires 'long' but the argument type is 'unsigned long'.
> net/bridge/br_sysfs_if.c(155): warning: %ld in format string (no. 1)
> requires 'long' but the argument type is 'unsigned long'.
> net/bridge/br_sysfs_if.c(148): warning: %ld in format string (no. 1)
> requires 'long' but the argument type is 'unsigned long'.
>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>
> ---
> net/bridge/br_sysfs_if.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
As I replied to your other patch with the same subject please squash them
together and send them targeted at net-next.
Thanks.
> diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c
> index 7a59cdd..16a7d41 100644
> --- a/net/bridge/br_sysfs_if.c
> +++ b/net/bridge/br_sysfs_if.c
> @@ -145,21 +145,21 @@ static ssize_t show_port_state(struct net_bridge_port *p, char *buf)
> static ssize_t show_message_age_timer(struct net_bridge_port *p,
> char *buf)
> {
> - return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
> + return sprintf(buf, "%lu\n", br_timer_value(&p->message_age_timer));
> }
> static BRPORT_ATTR(message_age_timer, 0444, show_message_age_timer, NULL);
>
> static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
> char *buf)
> {
> - return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
> + return sprintf(buf, "%lu\n", br_timer_value(&p->forward_delay_timer));
> }
> static BRPORT_ATTR(forward_delay_timer, 0444, show_forward_delay_timer, NULL);
>
> static ssize_t show_hold_timer(struct net_bridge_port *p,
> char *buf)
> {
> - return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
> + return sprintf(buf, "%lu\n", br_timer_value(&p->hold_timer));
> }
> static BRPORT_ATTR(hold_timer, 0444, show_hold_timer, NULL);
>
>
next prev parent reply other threads:[~2021-01-13 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 9:44 Jiapeng Zhong
2021-01-13 12:33 ` Nikolay Aleksandrov [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-13 9:36 Jiapeng Zhong
2021-01-13 12:31 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c4ef6ac-3d6f-121a-51bd-1abed4a75da4@nvidia.com \
--to=nikolay@nvidia.com \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®