From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C948231A23 for ; Sun, 31 May 2026 19:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780257506; cv=none; b=Wha+Sxw+82JdSNalBR9mw9p5t503FBFKSQ5sj2G7DTNtoOeMI2njAvz7K3JOOJgmzpvxxtug0a9pnP86xiY2Fckclw0cK6Kr8SnlnD9+Sb2k9AJT1H4wc/0j4TS+hnygjExJwEVlQ/KSdT2aZi2iVdrzA+g5Km6Kvm5XrxsVhuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780257506; c=relaxed/simple; bh=4d27iXqwYegfSxwa0tyuhz4yvb+d61tUAzALnsjixzQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lmOLfB0KxC8f77SG9ZPOhm5lCJpFhxHGv+IcEOrNkAc9NECUcN5ZGilug3qh7BFitS1l2+OEjhJ8x96LD4+skLq7sqxvK8GMH4iUF+HfN/qPc3LzK2hstSbCan8z/YHkDYVA2gZkO/yaFBc+9CINJTTYPijg6MzWzO20P0iflKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RbTVPKA/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g9k3xEbS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RbTVPKA/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g9k3xEbS" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64VIfuqT2567479 for ; Sun, 31 May 2026 19:58:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9EPVuHLNy9vtwwB1VoFU440/iMySrQARYXdbMN/T0bs=; b=RbTVPKA/5wmS3W0/ cUjJTZHMCY9tm2xDovY5HG/R+QoYu/vLCSihmbj5S16JknFgrb4b8OVo8TrTKZC1 qlIull9mxJRz4gP3mVRdPM5y8X5AS/VMdRWozNwUBYHvzeT6H7EWEWLxX9j+U1c3 lOFv6BdyVKD0UozxsAewMm1Zt7AGDUdaCucWB5h/xSIX+xI/feF5zj7pRg15cHkx xwC/QtaQXFkGd5NFhSqbHEXgcZWwqsadkgm1ELads0Z53OgGYApx2EFhkjKFnSwF MiibEEpyuuH6A00BYmutOu18Z6BntkVTnoPWU1BEFkE5Pirh7RhZlQn2VKgbvM+Y x1rGnA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efs2hc9d5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 19:58:24 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8ccd719a2f2so18238426d6.0 for ; Sun, 31 May 2026 12:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780257503; x=1780862303; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9EPVuHLNy9vtwwB1VoFU440/iMySrQARYXdbMN/T0bs=; b=g9k3xEbSgT6o/FzzCY1JH25oVlxIt8HdM25p3LSDysgvmsBfbtt2dfsGW1hqo+FXWd GUE0amgT7BJSkjR3tCUPhY/nx/AInao7mJym76Qo0xkL13orI1oZG0IfMAYBHBB8R9wx fYtv5wQEZMA3DMtDXfTErvSV8rHv9Fcks1DVSU6MBfW3Vqv/86VJlXvmnNaBxcSLLGXN Z7Xm7Kno1djfPxchmULGTCle2xcLP9ETt7MqL3ZeBr5dLhdPF/xnLJUuCKOGCZps88wR 0KFqPE2L7T1xmOP+G5Srga62gmaYAIlFBM1buRNtHDIBQTFyrCj9KfPeWQmQXhgYd6j4 SqEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780257503; x=1780862303; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9EPVuHLNy9vtwwB1VoFU440/iMySrQARYXdbMN/T0bs=; b=Ewf4dL2cAei3hI+tBU9Lo7WHKbMUlcMUIKjwRWPzz4gOUSF8sGddR+mlB1igy3jDrs MHmd91bIpJ84HIBriJTZfIM4xolGc/YVBJe4dXNNMSzZUGwE7bj0owUQSgRmX5UcHbH+ DOZAer1GI3tZE2jNIiK15tu+34h3/UR0v8hmGpn6i088YoOIpeXsF+F7DzsZEzSmYNnY OERxXF1fJFQDVA/sEuHAWpVmTYTT7AGUqa9bXj2g6+VbTNT0AWcDIhxyoH8bx98YBRmI f9tsP/hl2ZsKNfIdzrkfXASH8HRJiHgvpLrlwfrt3ms44fS1ieeD8UyJ8dI9kWJFvE0X Zvfw== X-Forwarded-Encrypted: i=1; AFNElJ+IsomALM4a4dKTy/x5cTAiJwhCxzHRISQUpc+fEiHHr2N70R6QKKYVA6r70/bEuo7CMNh6fqZnedtwvAg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0j72IuuwuzNM0i8lCxr4zhTX3NMfRjQyfZRwACZ2s1VA2XA3K pmE/9KjOO1FcoGZGCAtuC6TrqILwoAOhobgVVxt+DonyMU+0eheNmWfnyvAA5ls3l470qY7xBcj LilWkFwiEmA3omPSHo3acyxsLav8Rfd2r7Nk+42KNO9fz17NjLoycjP8+WcFkzv4gM0I= X-Gm-Gg: Acq92OFpM+9chDZXpAKl5jObB+UJV9SCg2Q181poCcIa6GUzdCozAG39Kcd6om47hf8 IL9f3F3tX0eTHSFXNKBQU3gWKQiSgHKwdkXXA/xPGL6pWLuFVGBAna0P7b7JhCBaACC5haLpj6G CEokdd53VXCp69UiiKIADsE05WMV4gOa+bHb5zzrnOTyWMFuVpv9oLlEXURoxsyiDjNp70cv3hN kTmajd2DlsbNAv/5PNvYbvnO16GGD9h3JOvUyqxzsv8M/KhSJoe5fu6fO0LQp+LxsCtAjAm80ZH nmLA7vAa9STEFctM4z9YEU3laIMS/wk6uZMJ8tQFfQuo69aYb3wKbNvp93oujjchf7V4GEbhjcM 1QCnCfrBRLSc+1fXCSdSMGyOIbA8YUxJW7Gg6T7s/KIMAfQjUnWx4lld5EIM1mFh7gQy7hFxx6F rB X-Received: by 2002:ac8:5143:0:b0:516:dede:2094 with SMTP id d75a77b69052e-5173a8b0d5cmr70777041cf.55.1780257503401; Sun, 31 May 2026 12:58:23 -0700 (PDT) X-Received: by 2002:ac8:5143:0:b0:516:dede:2094 with SMTP id d75a77b69052e-5173a8b0d5cmr70776921cf.55.1780257502956; Sun, 31 May 2026 12:58:22 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d68a925sm303091335e9.2.2026.05.31.12.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 May 2026 12:58:22 -0700 (PDT) Message-ID: <0c5033f7-1535-49e8-a502-426e54333496@oss.qualcomm.com> Date: Sun, 31 May 2026 21:58:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] firmware: meson: sm: add stub functions when CONFIG_MESON_SM is disabled To: Ronald Claveau Cc: Guillaume La Roque , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Mark Brown , kernel test robot , Neil Armstrong , Daniel Lezcano , Zhang Rui , "Rafael J. Wysocki" , Lukasz Luba References: <20260531-fix-missing-meson_sm-symbol-v2-1-1def8c3c169f@aliel.fr> <8c11a91b-cfbf-4b9c-a46f-907989bf8305@oss.qualcomm.com> <12d74340-0213-4f7e-a494-10ce147844ad@aliel.fr> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <12d74340-0213-4f7e-a494-10ce147844ad@aliel.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDIxNyBTYWx0ZWRfX0fA2AtsxLJw/ H3AdU0dmgboxw6Fdzo0QdoSIJfvrd9joHkBiAg+Aqc6f5IzvkfmT2xFiTdfht4tZxAgihjf0BEg G1yG7Kypm06BKhpHabKlHNMAyazjRU3skRlQsKBlYWXcEEu2J9a6u1KM4eucVm6mvFyKi82m96H TrV/dmEGnXcrOD90ioAVlUYxcZwKzNDlaHdU32BSwIIiNEJEgzNgCgCPuvVj//TQNOiR8Byl5fx BLwJmjaR0/bYv8e543kCw9gxTr670o1oHcDfFm4pQcaXZ1LJdj9M9OQQqZme6Drl1LT7eS2KpZj bxf/O7iHFsITyOYnFdv6gvuXpkZdLckAN3nbgEG/bKgt1Wmz6CqFjV68Ojh1DhEU3D84afl6zJs RH+GyHJe3fmrsVjBv8MP+SJH5ecwMCWC1dr1WJv3fjnu5i7rAgf0r/+fo2ifJsAWFEkHMiJBlQd Z6iZMbHGMSQuQtLy8QA== X-Proofpoint-ORIG-GUID: jeCiEN7hujN3FXPar6g_LD0CvNvE83Wj X-Proofpoint-GUID: jeCiEN7hujN3FXPar6g_LD0CvNvE83Wj X-Authority-Analysis: v=2.4 cv=UIvt2ify c=1 sm=1 tr=0 ts=6a1c92e0 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=uw/3876vWhRnNVL35W6mqQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=DmWT0VEtOxJI-Rt19aUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_06,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310217 On 5/31/26 19:49, Ronald Claveau wrote: > On 5/31/26 10:41 AM, Daniel Lezcano wrote: >> On 5/31/26 09:51, Ronald Claveau via B4 Relay wrote: >>> From: Ronald Claveau [ ... ] >>> +#if IS_ENABLED(CONFIG_MESON_SM) >>> + >>>   struct meson_sm_firmware *meson_sm_get(struct device_node >>> *firmware_node); >>>   int meson_sm_get_thermal_calib(struct meson_sm_firmware *fw, u32 >>> *trim_info, >>>                      u32 tsensor_id); >> >> Do you really want to compile meson_sm as a module ? >> >> >> > > I don't want, but if I send a patch to change tristate to bool, it will > raise a warning because 'm' is not valid. > If it is accepted to ignore this warning, I can send another patch. Sorry, I don't get your point :/ 'm' is a config option, make menuconfig should set it to yes or not set. Compiling the firmware as a module means it must be loaded before the amlogic thermal driver, right ? Where is the dependency declared in the module ? If the sm_meson is in the platform, it should be selected as part of the platform's component. No need to have an option for that, no ?