From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E90EC470130 for ; Wed, 22 Jul 2026 07:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784706029; cv=none; b=jobOAXYDqPrv371Ltkz9Bwo6yyV7UQ+NQbI0sW46F0SWTZdnlo2OpKYY1w28Xw7YdbVctjfPjSPe0mxUCvJC6/trUiGo0GBj5suI0hK13W0qm2KFg50abRgJplorLeMZeyuwHv023FGSTlZTB/K+xmMIiWgF/XehKVpr/xmvLOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784706029; c=relaxed/simple; bh=swFDNlNTbzSmuQjfxksa3smW5BDv4wRCtW3Ecnxg8V4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GjpGFW9ZJ7XBxxpOW9xYuzBJbeRf0FQqroCWz0Jnx+ftPYmdRX+qzndTF1jSQ60fB+6NEQRm/YgfZkoskGpFTesaQa7tbN0usj3gOQDSTvSbO8IYyf1AuyMHmPc37I03ieubBkFD1AB9P0YZw/yIRm9t5CPXoBhOCTgqDjOuqjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a6Aiptuv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DuTHNAtX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a6Aiptuv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DuTHNAtX" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M61qGx984397 for ; Wed, 22 Jul 2026 07:40:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=T/sjeRpn9BssHS0FCtGdQxM5 xUeDnRf/+QPldCey/10=; b=a6AiptuvNdJiTbm64FRiiwTW4/xZa1RuSpl6OVUl 4QPetK5kihgfJFPFKj7iMnQV4q3npN1dTs81MkXarbti4nzalNQJQ+vnJx3+d5ja Pqbt5OQOpJup6Z/x8DgC9EPu21QubXNJKDRBnwoCcUOmh434Ow/ZlIhYH8EP5OYM UkHorDzdJUt0fjixZJI5/TfAViZG+fUuCCMMpF+uPrRpsoEa55J4MPAw+4d9l0Ac H67NO3iFRdrZvIKQk7ng8oqe2ShZ3PxrsOpSjC5eOuxyyvaxUuQG+qiOhYL4mpzg KEiZJDbfGXRkkJsFq0iaxNnk9u+Srd4hjO00MJ/PmUtOuQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjr838d4n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 07:40:26 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-385d2703b64so5724941a91.1 for ; Wed, 22 Jul 2026 00:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784706026; x=1785310826; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=T/sjeRpn9BssHS0FCtGdQxM5xUeDnRf/+QPldCey/10=; b=DuTHNAtXxsQHMIaBqGoPTh6G5C5gD04og1gQABF/gF39fx42m1mbvlBFpOqXC1Zlzo GQaWmrh4lZEEqPEKExe8es6nAHidWhlcVqIzesaWnapw4YbjIdgtxf8t7f5IQ/CE0wEl SfrEglklUUo9YT8/aZFrD3orvyIw36YX/rFSJC7KoVQPcVu34KZoq0+yBeoJY84Z/Aus wcc4DPoQ+ZqIxWNAw1pBjCLoDm20WCDbQS1U8/gx0sNQFWiXzYh7HkEW+F6xnWpyYOwm zzZgr4XytUEcvA0tvJfzJq2BgyyLBuFLPwqkWMxNddL6f3fgcG9P2H4nZOx81HzV4pRy cA7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784706026; x=1785310826; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T/sjeRpn9BssHS0FCtGdQxM5xUeDnRf/+QPldCey/10=; b=tWIZAmN7qnL/DlwIRul+76bQilhI4RiMrdVLl3l/HCPiXvpSDd1rWPDd32JecuV2N5 k+jYFooGz80ol6C7M/YNguaECiuFgDG1Q2rLXdE/EUV8L70RvXngdPe9g8Sh9LBZoajX ltycoqZmIt2cBjhkOjYuOvhpzTU9DKQ7utOMK0hTbihHSkwM952H2rWqK6fDXytXRf3M EU2/nnk4d5awp0dhPAsES0LrlzTeRlGSKixqdu6yJyTfFHC/hRaCe4+2WNpjOn3pBS7S 7Jw+qmOeR51s8LejvGpYolSbJ4KHM7RyyItfxnBDQs1yXlZ78cRmYQj9wHPj+I6CzyeF 9GeQ== X-Forwarded-Encrypted: i=1; AHgh+RrInOK1xLhlPUockbaj8oLfo3liynUayEqpNG1qgZrCGq7pBxyZBHDrdzCtAb1gf8M1gwPBhks05dqEt2M=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc5gNLF3QgH1mUDxYeYE7xvGwCEM0+wVoLtc1vBIjrmMnWD9on P4Jjj5Kac3YsYjWERoWYaHtNAbcpgxsm3TGsOPN7PqwpB6uBrnQSe7MUlfAy7lBFXuaV0zvp/pt 37DyvQRxMvolF5EtNKX1jWwkTFw/4obHWvdUdqJ0XwJnOU5+Ng0qbP4GEs/YnWioxFG4= X-Gm-Gg: AR+sD13CcKXhLje5Q4Xf3dJ9qSqvqG6muidLRduFzAmWWHCfp0wufUJm58l+n3orgGd BrVsJ6ivmnUzuDhMh8MujNb++RDsuvs9k5VFtWNbVguXIXZw27CCL+Bu9u7pgSE1iM32FCzjMst vfKucr3L5gAFEafokSf5P686EjMDMDHabd6yINJ50zkQdRNAmbToCqwim0ql2+s22RrBX+xxAAl ip8pyn1/dYZ2DjO3lNiMLhZUyz6OlMXXemMyYhZQLRxNdx6snFlcTPknEUCkBbX9+4gXhhIw6B/ PygfI5CBN24ZmjRXaA0l1qGHT9OFzQODgccWWQe6A+7TLp3xsd678MJtfoQqpNsFqve/z7I6jfD g4qqGaeFhb5BfeCte+YS8LBks1KMJarNVRA== X-Received: by 2002:a17:90b:5844:b0:37f:a913:1554 with SMTP id 98e67ed59e1d1-38ea37961d2mr2544866a91.16.1784706026135; Wed, 22 Jul 2026 00:40:26 -0700 (PDT) X-Received: by 2002:a17:90b:5844:b0:37f:a913:1554 with SMTP id 98e67ed59e1d1-38ea37961d2mr2544812a91.16.1784706025638; Wed, 22 Jul 2026 00:40:25 -0700 (PDT) Received: from hu-pkondeti-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d130a7738sm3935997c88.9.2026.07.22.00.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 00:40:25 -0700 (PDT) Date: Wed, 22 Jul 2026 13:10:13 +0530 From: Pavan Kondeti To: Shivendra Pratap Cc: Sebastian Reichel , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Ulf Hansson , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Souvik Chakravarty , Andy Yan , Matthias Brugger , John Stultz , Moritz Fischer , Bartosz Golaszewski , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , mfd@lists.linux.dev, Srinivas Kandagatla Subject: Re: [PATCH v23 03/13] power: reset: reboot-mode: Add support for predefined reboot modes Message-ID: <0c55125d-5304-415d-86c0-a589c612babf@quicinc.com> References: <20260714-arm-psci-system_reset2-vendor-reboots-v23-0-e7453c548c21@oss.qualcomm.com> <20260714-arm-psci-system_reset2-vendor-reboots-v23-3-e7453c548c21@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260714-arm-psci-system_reset2-vendor-reboots-v23-3-e7453c548c21@oss.qualcomm.com> X-Proofpoint-ORIG-GUID: Hc9Tj1qu3473lmZKgx_sXd_hcnSXUILW X-Authority-Analysis: v=2.4 cv=VfrH+lp9 c=1 sm=1 tr=0 ts=6a6073ea cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=ZcGSZn2CXGzCaGrIrKoA:9 a=CjuIK1q_8ugA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: Hc9Tj1qu3473lmZKgx_sXd_hcnSXUILW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA3MCBTYWx0ZWRfX7353oyhkBl9G RkHf/IGRd1vSUcm2XMKHGUjkLsfB/8XAJs6ln+vqZ5ggziNcYDUplQ3zBSu+DsrSmOAiTuLq6mA olXYFMMwG/nDp4twgsUBXUZzZelRh2171jKWYai29tOJjA76p57dTNm7+VqTHSk9+NIXL3U0JZs 05PGSY24VNOwHzAii6vy8F5MNoQlm6R8RL4RlPI/4nw3oz2/GGE9wOrWT6VvLLS5jikVIKRgo1/ 7erLGcWIQfXRGtV+wVy/1xOJ+nOg3yVXOmaGgVyEnNqS4EYYROYxurrJpCuTdB5sDr0E2+dlrFh zrS6L+LE0i65BgitoPl0SX02IBYBzm7eEQzie/kK5YCDl0e+Gd5DJNcqxttHsAsFbk6aV5D6v1r 9LFblAoijeERV32nl3SNHkDuSnf1bYlrnZuJsvOlJJBoae5Yy9YSYDwSMHq4fl/aA6SsmSn1paG RAvZWGgNg4R4A8/SpJQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA3MCBTYWx0ZWRfXxRmP1u90t1+J g6VvLXgj4p8JXD1MZtzpyVIrkbqhQ6TH/LIUX/eC/rSKYhom3MWNWuX2eoLUw4wR4KweuYjgflC 0t5XYCUfevH5ONti7BBL63iWnK1B1XY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_02,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220070 On Tue, Jul 14, 2026 at 10:46:31PM +0530, Shivendra Pratap wrote: > reboot-mode based drivers can define a reboot-mode by adding it under > the reboot-mode node in device tree. This limits such drivers, to define > any predefined reboot-modes statically within the driver and creates a > dependency on device-tree. > > Extend the reboot-mode framework to handle predefined modes alongside > those defined in device tree. Drivers can now define their own > reboot-modes and register them via the framework. A centralized init > call has been added to the reboot-mode framework and adopted by > existing drivers. This ensures driver state is initialized together > with predefined modes. > > Signed-off-by: Shivendra Pratap > @@ -195,35 +264,17 @@ int reboot_mode_register(struct reboot_mode_driver *reboot) > continue; > } > > - info = kzalloc(sizeof(*info), GFP_KERNEL); > - if (!info) { > - ret = -ENOMEM; > - goto error; > - } > - > - if (!memchr_inv(magic, 0, count * sizeof(u32))) { > - pr_debug("reboot mode %s with zero magic values\n", prop->name); > - info->count = -1; > - } else { > - memcpy(info->magic, magic, count * sizeof(u32)); > - info->count = count; > - } > - > - info->mode = kstrdup_const(prop->name + len, GFP_KERNEL); > - if (!info->mode) { > - ret = -ENOMEM; > - goto error; > - } else if (info->mode[0] == '\0') { > - kfree_const(info->mode); > - ret = -EINVAL; > - pr_err("invalid mode name(%s): too short!\n", prop->name); > + info = reboot_mode_create_info(prop->name + len, magic, count); > + if (IS_ERR(info)) { > + ret = PTR_ERR(info); > goto error; > } > > list_add_tail(&info->list, &reboot->head); > - info = NULL; > } > > +predefined_modes: > + list_splice_tail_init(&reboot->predefined_modes, &reboot->head); > reboot->reboot_notifier.notifier_call = reboot_mode_notify; > register_reboot_notifier(&reboot->reboot_notifier); > This splice here makes me ask why we need separate API for registering pre-defined reboot modes? why not extend `struct reboot_mode_driver` to pass on the pre-defined modes and let `reboot_mode_register()` take care of both OF & pre-defined modes. The semantics of `reboot_mode_reset_predefined_modes()` is very confusing. It is not clear if any client driver needs to really call before unregistering? The unregister it self is cleaning up these pre-defined modes since they are spliced. Thanks, Pavan