mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Christian Brauner <christian.brauner@ubuntu.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	christian@brauner.io, shuah@kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3 0/2] selftests: pidfd: prefer ksft_test_result_skip to ksft_exit_*
Date: Tue, 7 Jul 2020 08:47:42 -0600	[thread overview]
Message-ID: <0c56c23f-284c-6904-8403-b2183eae2574@linuxfoundation.org> (raw)
In-Reply-To: <20200707135257.u65ggyr2hcgjfgyh@wittgenstein>

On 7/7/20 7:52 AM, Christian Brauner wrote:
> On Tue, Jul 07, 2020 at 06:19:34AM -0400, Paolo Bonzini wrote:
>> Calling ksft_exit_* results in executing fewer tests than planned, which
>> is wrong for ksft_exit_skip or suboptimal (because it results in a bail
>> out) for ksft_exit_fail_msg.
>>
>> Using ksft_test_result_skip instead skips only one test and lets the
>> test plan proceed as promised by ksft_set_plan.
>>
>> Paolo
> 
> Thanks for fixing this, Paolo!
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> 
> Shuah, want me to take it or do you want to take it?
> 

I will apply it to my tree with Paolo's other patches in this series.

thanks,
-- Shuah

      reply	other threads:[~2020-07-07 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 10:19 Paolo Bonzini
2020-07-07 10:19 ` [PATCH v3 1/2] selftests: pidfd: do not use ksft_exit_skip after ksft_set_plan Paolo Bonzini
2020-07-07 15:24   ` Shuah Khan
2020-07-07 10:19 ` [PATCH v3 2/2] selftests: pidfd: skip test if unshare fails with EPERM Paolo Bonzini
2020-07-07 13:52 ` [PATCH v3 0/2] selftests: pidfd: prefer ksft_test_result_skip to ksft_exit_* Christian Brauner
2020-07-07 14:47   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c56c23f-284c-6904-8403-b2183eae2574@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=christian@brauner.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®