From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Mary Strodl <mstrodl@csh.rit.edu>,
linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org, Mary Strodl <mstrodl@csh.rit.edu>
Subject: Re: [PATCH v2] gpio: add support for FTDI's MPSSE as GPIO
Date: Wed, 25 Sep 2024 11:18:20 +0300 [thread overview]
Message-ID: <0c58010f-3d25-498b-a519-d79e7021cff1@stanley.mountain> (raw)
In-Reply-To: <20240919141014.4000958-1-mstrodl@csh.rit.edu>
Hi Mary,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mary-Strodl/gpio-add-support-for-FTDI-s-MPSSE-as-GPIO/20240919-221626
base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link: https://lore.kernel.org/r/20240919141014.4000958-1-mstrodl%40csh.rit.edu
patch subject: [PATCH v2] gpio: add support for FTDI's MPSSE as GPIO
config: x86_64-randconfig-161-20240922 (https://download.01.org/0day-ci/archive/20240923/202409230158.XhvhLOyY-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202409230158.XhvhLOyY-lkp@intel.com/
smatch warnings:
drivers/gpio/gpio-mpsse.c:211 gpio_mpsse_get_multiple() warn: inconsistent returns '&priv->io_mutex'.
vim +211 drivers/gpio/gpio-mpsse.c
be777399e9baea Mary Strodl 2024-09-19 190 static int gpio_mpsse_get_multiple(struct gpio_chip *chip, unsigned long *mask,
be777399e9baea Mary Strodl 2024-09-19 191 unsigned long *bits)
be777399e9baea Mary Strodl 2024-09-19 192 {
be777399e9baea Mary Strodl 2024-09-19 193 unsigned long i, bank, bank_mask;
be777399e9baea Mary Strodl 2024-09-19 194 int ret;
be777399e9baea Mary Strodl 2024-09-19 195 struct mpsse_priv *priv = gpiochip_get_data(chip);
be777399e9baea Mary Strodl 2024-09-19 196
be777399e9baea Mary Strodl 2024-09-19 197 mutex_lock(&priv->io_mutex);
be777399e9baea Mary Strodl 2024-09-19 198 for_each_set_clump8(i, bank_mask, mask, chip->ngpio) {
be777399e9baea Mary Strodl 2024-09-19 199 bank = i / 8;
be777399e9baea Mary Strodl 2024-09-19 200
be777399e9baea Mary Strodl 2024-09-19 201 if (bank_mask) {
be777399e9baea Mary Strodl 2024-09-19 202 ret = gpio_mpsse_get_bank(priv, bank);
be777399e9baea Mary Strodl 2024-09-19 203 if (ret < 0)
be777399e9baea Mary Strodl 2024-09-19 204 return ret;
Needs to mutex_unlock(&priv->io_mutex) before returning.
be777399e9baea Mary Strodl 2024-09-19 205
be777399e9baea Mary Strodl 2024-09-19 206 bitmap_set_value8(bits, ret & bank_mask, i);
be777399e9baea Mary Strodl 2024-09-19 207 }
be777399e9baea Mary Strodl 2024-09-19 208 }
be777399e9baea Mary Strodl 2024-09-19 209 mutex_unlock(&priv->io_mutex);
be777399e9baea Mary Strodl 2024-09-19 210
be777399e9baea Mary Strodl 2024-09-19 @211 return 0;
be777399e9baea Mary Strodl 2024-09-19 212 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2024-09-25 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 14:10 Mary Strodl
2024-09-22 20:30 ` Linus Walleij
2024-09-22 22:44 ` Linus Walleij
2024-09-23 15:50 ` Mary Strodl
2024-09-25 8:18 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c58010f-3d25-498b-a519-d79e7021cff1@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mstrodl@csh.rit.edu \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®