From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11CB850391C for ; Wed, 14 Oct 2026 12:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791982394; cv=none; b=EWEXzYpcxZ2P/r37AF9glSpgE7CMypg0HTvStZPLSKx+u/XS9uC5Uksd/gBBYqsLr5gzj6zfB/rryLLRIdzKpTROl6mdQWg17upLbXT9mk6zjgLw7SIqf6J9XbAXZQx/XsH2vYr8kcPrbWEb1GMBWb6sILwrDvqgj8JPFx3HuJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791982394; c=relaxed/simple; bh=M/AuqUeZeqqptr6S7+fLJ7PsEa0zA0B04uQhsnX8ZVI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pz8Aq5LqNx33bur1+XK6un+VWerjw9hJQmTbcSUNPtOEbbNr25Au6DhoViC8fvopogO2SL59nY6D/TlBQSagdJAqZMlxyt1tINzbLfyxGSMpQwjwtCtnGAQl6i7Z/Kxq+ZI/7YAS+wCxp7/5TER3faqQROYAIfCcFDgSZ4LiqPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BZCPftzG; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BZCPftzG" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4a1880e1bf1so8364315e9.1 for ; Wed, 14 Oct 2026 05:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1791982360; x=1792587160; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=7agUasRQggBe8XU1P9665BVX4s2h0H7hyBLdn0AXob8=; b=BZCPftzGmYuW5oKfk+qZn9/EfmML3cHYdsI3dyL8Z7Jpx7G9vlKa6xxkG1eocEQlNa 2YxR3UlcRRc0kyZHf9BL57mxRxkpJ506/ZmRWyb/S5Qs+0R4JaP8+gUcDKkeYBdD9oKH sKbw3jpyC1Z6B3t5WT5XI2QE8bTX/1k8DMtWgSLLmu+OtJAsbCRiouJTUOnzupciXjMq IHz3HMHY+CDrzC2eArB0+3IG4vBRm9YHhU4zdHV62kpFQB/8Xf3joxr5o7BA4vLWrODS hi9itl/ao6WfGibvDUVXu3Vd6Bu3s+0b5KUOziUn0e5ty6yPsmxbFFs5m06873MS/5yv sYdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791982360; x=1792587160; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=7agUasRQggBe8XU1P9665BVX4s2h0H7hyBLdn0AXob8=; b=fXzi/GAackdna0JpLVCbec6YkitF9Bw0A+XlzZkf0JB4C25r2XwNC0MW8ODmyAdohE kUolteYOva4EZgY36UKb9avJV4S7I3JKk5XKrhiIWGiXeWOxdb5kp/kKXTFCknQKbpKB cnxvAx9xqL8gDUhOlj4vF+alv02biZVOi1/7i78DSTktEy2RkloihiCB29LyuXJKW41o 86lUMqJERIOglDsADcdfe1mk3j10aFS08uE28mC6GV9bJIi2xHJjPgFNsPs6N8cnc3Co KTAvXtziGZ+yPK7hrzWhp4WR/YQovoQ6YcP0fDcw8qkA/VSRess2WOvQecOIQ12rXi0/ VGXQ== X-Forwarded-Encrypted: i=1; AKwUvBxYf+wcRCnvBA8FJoEw8pv+c7PW83XoMqfSvyNAkoaAJlCMFaPF/3NAYbsW+8n+w72/z+ax0GkaVS9/RGo=@vger.kernel.org X-Gm-Message-State: AFq9FYKc6tBDXCHH8JZF8HV2mRB8ttARNMrFqBrP7uLyVTH+iolHciCM /otcJsUDkXBu2Up1fJk3BAR3sfUPf9f2Aa43BzpyYD/ZAG2sq8m3sCfMTePuylJMCRY= X-Gm-Gg: AYBFou0IbzQa7rHjtljw+G11biG34B/M89QC7UkLXIuGI9vAFtTQpitYylGCOfZgl0z SPZe7KMsZrd5+sx+1bIe/fFgj2AvOuiX/5whVJvcRJVhiiqFRZCQ632EGjshb4a4H9pUqVCS8Fr sgxGozSiYfpXBZUPpxa3GP69qV8PExI66H0jIn0WX+zh8umzyfscI2igpGzPVRISySS630brc22 rPYEfw2S9tBz/AUA/Wt0zIZrTZFEfFIgxjkunkF1ScE/D9mNBLb6nbssLNT/4W0PoBaC8r8PeGm SXIE5dMAfVeR0OBTNrNEui9R5dgJHmgD8mPLxU9gjqitz/SaqOvOMSA+/SGtnBgu66Wz6fbSWwE jIWP/7FywPpqV5segrMyQaGxEBRFbfv65Ggy+tMJWodTu5W/lWJxDbEUpcHBeDMqgyLJTrmFepo 7C3Fbixd7HemDEVj7YhQ4rLpbOliCMXDbX+tjdvb0yHOy5qshsJ6R690fMNlsxObAStgF3sVwEN UDWnJ+LHFBUI+elhFpmV1RPL20NTm1a5A== X-Received: by 2002:a05:600c:a01:b0:49f:ce72:e931 with SMTP id 5b1f17b1804b1-4a18e4fe3e1mr329265145e9.35.1791982359832; Wed, 14 Oct 2026 05:52:39 -0700 (PDT) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [185.218.66.243]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1b2e9791csm46488065e9.1.2026.10.14.05.52.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 05:52:37 -0700 (PDT) Message-ID: <0c5851bb-456f-4191-b951-94c8c3916ad3@suse.com> Date: Wed, 14 Oct 2026 15:52:34 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 05/15] virt: tdx-guest: Add TDCM helpers and TEE-IO support check To: Zhenzhong Duan , x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dave.hansen@linux.intel.com, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, dave.hansen@intel.com, kas@kernel.org, rick.p.edgecombe@intel.com, jgg@nvidia.com, nicolinc@nvidia.com, aik@amd.com, aneesh.kumar@kernel.org, seanjc@google.com, pbonzini@redhat.com, yilun.xu@linux.intel.com, chao.gao@intel.com, vishal.l.verma@intel.com, xiaoyao.li@intel.com, kevin.tian@intel.com, chao.p.peng@intel.com References: <20260924041032.1096569-1-zhenzhong.duan@intel.com> <20260924041032.1096569-6-zhenzhong.duan@intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260924041032.1096569-6-zhenzhong.duan@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 24.09.26 г. 7:10 ч., Zhenzhong Duan wrote: > Implement internal helper wrappers tdx_tdcm_alloc(), tdx_tdcm_run(), > and tdx_tdcm_free() to manage execution context lifecycle for TDX Connect > TEE-IO Device Control and Management (TDCM) commands. > > Use these infrastructures to deploy all TDCM commands to orchestrate > trusted device management, beginning with the first command, > TDCM_OP_CHECK_TEEIO_SUPP, executed during the secure device locking > sequence. > > Signed-off-by: Zhenzhong Duan > --- > arch/x86/include/asm/tdx.h | 48 +++++++++ > drivers/virt/coco/tdx-guest/connect.c | 139 ++++++++++++++++++++++++++ > 2 files changed, 187 insertions(+) > > diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h > index 4937e23d5483..71cd701d346f 100644 > --- a/arch/x86/include/asm/tdx.h > +++ b/arch/x86/include/asm/tdx.h > @@ -105,6 +105,54 @@ int tdx_mcall_extend_rtmr(u8 index, u8 *data); > u64 tdx_hcall_get_quote(u8 *buf, size_t size); > > #ifdef CONFIG_TDX_CONNECT_GUEST > +enum tdcm_operation { > + TDCM_OP_CHECK_TEEIO_SUPP = 1, > + TDCM_OP_BIND = 2, > + TDCM_OP_GET_DEV_INFO = 3, > + TDCM_OP_GET_TDI_REPORT = 4, > + TDCM_OP_START_TDI = 5, > + TDCM_OP_GET_TDI_STATE = 6, > + TDCM_OP_UNBIND = 7, > +}; > + > +enum tdcm_status { > + TDCM_STATUS_WAIT = 0, > + TDCM_STATUS_COMPLETED = 1, > + TDCM_STATUS_ERROR = 2, > +}; > + > +enum tdcm_error { > + TDCM_ERROR_TDX_MODULE = 10, > + TDCM_ERROR_TDXIO_DEVICE = 11, > + TDCM_ERROR_SPDM_MESSAGE = 12, > + TDCM_ERROR_IDE_KM_MESSAGE = 13, > + TDCM_ERROR_TDISP_MESSAGE = 14, > + TDCM_ERROR_INVALID_STATE = 15, > +}; > + > +struct tdvmcall_tdcm { > + __u16 operation; /* See enum tdcm_operation */ > + __u8 version; > + __u8 rsvd0; > + __u32 rsvd1; > + > + __u8 status; /* See enum tdcm_status */ > + __u8 error; /* See enum tdcm_error */ > + __u16 rsvd2; > + __u32 rsvd3; > + > + __u32 data_length; > + > + __u8 data[]; > +} __packed; > + > +struct tdcm_rsp_check_teeio_supp { > + __u8 is_supported; > + __u8 data[]; > +} __packed; > + > +#define MAX_TDI_REPORT_SIZE (16 * PAGE_SIZE) Since TDCM and all concepts around it are coupled to TDX Connect why are those defines in the shared tdx.h file? OTOH, why is struct tdcm_ctx {} defined in connect.c and not in the shared file? I think it's high time we decided whether code coming for additional functionality should go into the shared header or a file, specific to said functionality. My 2 cents are that since TDCM is solely related to connect then it should probably be part of connect.h or some private header under tdx-guest/ directory. It's not expected for kernel proper to use that interface, no ?